Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#9633 closed Patch - Feature (fixed)

Progress bar for osd-browse window

Reported by: Markus Schulz <msc@…> Owned by: markk
Priority: minor Milestone: 0.25
Component: MythTV - Video/OSD Rendering Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

i've added a progress bar (show the elapsed time of the show as progress bar) to the osd browse window.

you must add something like:

<progressbar name="elapsedpercent">

<area>500,1050,1050,33</area> <layout>horizontal</layout> <style>reveal</style> <imagetype name="background">

<area>0,0,1050,33</area>

<filename>images/progressbar/progressbar_large_background.png</filename> </imagetype> <imagetype name="progressimage">

<area>0,0,1050,33</area> <filename>images/progressbar/progressbar_large_fill.png</filename>

</imagetype>

</progressbar>

to the browse_info window in osd.xml

Attachments (7)

osdprogressbar.diff (4.5 KB) - added by Markus Schulz <msc@…> 9 years ago.
patch
progressbar-screen1.jpg (94.8 KB) - added by sphery 9 years ago.
Sample screenshot 1
progressbar-screen2.jpg (120.1 KB) - added by sphery 9 years ago.
Sample screenshot 2
0001-ProgressBar-OSD-Patch-v2.patch (5.0 KB) - added by Markus Schulz <msc@…> 9 years ago.
new Version, use timediff for correct results for shows running thru 00:00
0001-ProgressBar-OSD-Patch-v4.patch (1.9 KB) - added by Markus Schulz <msc@…> 8 years ago.
new version
0001-ProgressBar-OSD-Patch-v5.patch (2.3 KB) - added by Markus Schulz <msc@…> 8 years ago.
ProgressBar?-OSD-Patch-v5
mythtv-master-ticket9633_progressbar_on_osd.patch (650 bytes) - added by warpme@… 8 years ago.
Make progress bar on info only for current LiveTV

Download all attachments as: .zip

Change History (19)

Changed 9 years ago by Markus Schulz <msc@…>

Attachment: osdprogressbar.diff added

patch

comment:1 Changed 9 years ago by Markus Schulz <msc@…>

sorry, the sample screenshots are jpeg files without file extension. can an admin add the extension?

Changed 9 years ago by sphery

Attachment: progressbar-screen1.jpg added

Sample screenshot 1

Changed 9 years ago by sphery

Attachment: progressbar-screen2.jpg added

Sample screenshot 2

Changed 9 years ago by Markus Schulz <msc@…>

new Version, use timediff for correct results for shows running thru 00:00

comment:2 Changed 8 years ago by Raymond Wagner

Status: newassigned

Changed 8 years ago by Markus Schulz <msc@…>

new version

comment:3 Changed 8 years ago by Markus Schulz <msc@…>

I've added a new version. Now without changes to db-query and ProgramInfo? interface. Elapsed percent value now will be calculated in OSD::SetText?() to get better accuracy (db-qery was not executed often enough).

comment:4 Changed 8 years ago by warpme@…

Hi, I really like this functionality. Thx You decided to share it with us. I used v2 with great success (albeit sometimes progress reported by OSD was somehow incorrect). Unfortunately v4 crashes FE durring browse on programs which have 0min length. In my case it was on programs without EPG. Issue is present in only in v4. v2 works OK. Br

Changed 8 years ago by Markus Schulz <msc@…>

ProgressBar?-OSD-Patch-v5

comment:5 Changed 8 years ago by Markus Schulz <msc@…>

ok, v5 now prevents division by zero.

comment:6 Changed 8 years ago by warpme@…

Thx. Working perfectly. One question: current implementation starts to show progress bar when user enter browse mode. When user starts LiveTV and press info, progress bar is not shown for current program. For showing progress bar user have to enter browse mode. Nothing wrong with this. Many commercial STB however shows progress bar also for current program. Indeed, during months of usage I many times enter browse mode just to see progress of current program. Is it possible to functionally extend this nice patch also to show progress bar for current show ?

comment:7 Changed 8 years ago by Markus Schulz <msc@…>

you can already do this, you must only add a similar <progressbar name="elapsedpercent"> block to the <window name="program_info"> block of your osd.xml

comment:8 Changed 8 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: assignedclosed

TV: Add an 'elapsedpercent' progress bar to the OSD.

This allows themers to display the current position (relative to the scheduled data) of a program in live tv - which fits nicely with both browse mode and the Info screen.

No themes have been updated - I'll leave that to themers.

Closes #9633

Branch: master Changeset: 1d29fd650a414c448b597e020b59993f66f23ec4

comment:9 Changed 8 years ago by warpme@…

Mark, Thx for including this nice functionality into main code. I used it months with browse_info in LiveTV. I intentionally not include 'elapsedpercent' in program_info container as - while it nicely shows progress for just entered LiveTV - it unfortunately shows 0 or 100% on recordings program_info. This is somehow confusing for user, and also quite redundant as for recordings, user already has progress info in dedicated pop-up window. Is it possible to modify commit functionality that 'elapsedpercent' is drawn in program_info & browse_info containers but only for LiveTV ?

comment:10 in reply to:  9 ; Changed 8 years ago by Markus Schulz <msc@…>

Replying to warpme@…:

Mark, Thx for including this nice functionality into main code. I used it months with browse_info in LiveTV. I intentionally not include 'elapsedpercent' in program_info container as - while it nicely shows progress for just entered LiveTV - it unfortunately shows 0 or 100% on recordings program_info. This is somehow confusing for user, and also quite redundant as for recordings, user already has progress info in dedicated pop-up window. Is it possible to modify commit functionality that 'elapsedpercent' is drawn in program_info & browse_info containers but only for LiveTV ?

if we disable the progressbar if it is 100% filled (now_ts >= end_ts) then this should do it correct without check for watch livetv/recording.

comment:11 in reply to:  10 Changed 8 years ago by markk

Replying to Markus Schulz <msc@…>:

if we disable the progressbar if it is 100% filled (now_ts >= end_ts) then this should do it correct without check for watch livetv/recording.

While that would work, it means that a theme element is not displayed under certain circumstances which, depending on how the theme is designed, will leave blank/unused areas of the theme.

The alternative is to adjust the code and add an info screen just for live tv. Themers would then need to create another (perhaps optional) info window (though in many situations it would largely be a copy of the existing window).

comment:12 Changed 8 years ago by warpme@…

Right. My idea was exactly as 2\ option mentioned by Mark (add info screen for LiveTV). Fortunately attached mod to Markus code seems to be quite consistent from functional point of view (progress is drawn only for current program only in LiveTV) and seems to be reasonable compromise between consistency & workload. Sure, current implementation might be considered as little not consistent in theming area (info_container has different content between recording & LiveTv?) - but this seems to be quite minor thing....

Changed 8 years ago by warpme@…

Make progress bar on info only for current LiveTV

Note: See TracTickets for help on using tickets.