Opened 13 years ago
Closed 12 years ago
#9645 closed Patch - Bug Fix (fixed)
[PATCH] WIN32_LEAN_AND_MEAN
| Reported by: | Owned by: | beirdo | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | Ports - Windows | Version: | Unspecified |
| Severity: | medium | Keywords: | Windows |
| Cc: | Ticket locked: | no |
Description
This patch defines WIN32_LEAN_AND_MEAN and NOMINMAX when building mythtv and mythplugins for Windows. This change should avoid a lot of name hijacking that occurs when including windows.h. The patch also fixes several files that were missing explicit headers.
Attachments (1)
Change History (6)
Changed 13 years ago by
| Attachment: | win32-lean.diff added |
|---|
comment:1 Changed 13 years ago by
| Status: | new → infoneeded_new |
|---|
comment:2 Changed 13 years ago by
This patch isn't _necessary_ to build Myth for Windows but it does reduce the probability of problems in the future. It removes a lot of superfluous names and defines from the global namespace and forces programmers to think about and explicitly add headers for the Win32 functions that they use.
NB by default VisualC defines these for all new projects.
comment:3 Changed 12 years ago by
| Status: | infoneeded_new → new |
|---|
comment:4 Changed 12 years ago by
| Owner: | changed from Nigel to beirdo |
|---|---|
| Status: | new → assigned |
comment:5 Changed 12 years ago by
| Milestone: | unknown → 0.25 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Define WIN32_LEAN_AND_MEAN and NOMINMAX for MingW
This patch defines WIN32_LEAN_AND_MEAN and NOMINMAX when building mythtv and mythplugins for Windows. This change should avoid a lot of name hijacking that occurs when including windows.h. The patch also fixes several files that were missing explicit headers.
Closes #9645
Signed-off-by: Gavin Hurlbut <ghurlbut@…>
Branch: master Changeset: acadd66dbd50be2a8b98031d2f1d7400fbca951f
Is this still necessary? Or has this been worked out in subsequent patches?