Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9828 closed Bug Report - General (fixed)

DVD: segfault on double free in dvdnav

Reported by: linux@… Owned by: robertm
Priority: minor Milestone: 0.25
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I noticed a segfault in dvdnav on one of my discs due to a double free when faulty country info is found in the parental management information description. Further investigation showed that this problem has already been fixed upstream (http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2010-November/001322.html) with SVN id 1220.
The attached patch is based on the upstream commit but fixes a tiny memory leak in the upstream version as well.

I'd like to ask you to apply the patch because currently trying to play the DVD kills the whole frontend. If you are planning a resync with upstream dvdnav anyway then the patch is not needed of course.

Thanks and best wishes,

Martin.

Attachments (1)

0001-Fix-for-double-free-in-libdvdnav-taken-from-dvdnav-s.patch (2.3 KB) - added by linux@… 3 years ago.
patch for double free in dvdnav, based on upstream SVN commit 1220

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by linux@…

patch for double free in dvdnav, based on upstream SVN commit 1220

comment:1 Changed 3 years ago by robertm

  • Owner changed from markk to robertm
  • Status changed from new to assigned

I'll do a resync in the next few days, I had already looked at this in the last few weeks. Doing piecemeal resyncs just makes it too hard to resync later.

comment:2 Changed 3 years ago by robertm

Martin, I'm preparing a resync, but if you want improvements to upstream included, I'll need you to get them committed there. We can't allow our source to diverge from upstream any more than necessary to support the myth protocol. Have you submitted these there yet? Erik Hovland from the dvdnav/read team is a Myth user.

comment:3 Changed 3 years ago by Github

  • Milestone changed from unknown to 0.25
  • Resolution set to fixed
  • Status changed from assigned to closed

libmythdvdnav: Resync dvdnav and dvdread.

This covers upstream SVN revisions 1216-1226. Covers the following changes:

libdvdnav:

  • Prevent abort if a menu doesn't exist.
  • Fix typos
  • Fix grammar in dvdnav.h
  • Fix typos in comments

libdvdread:

  • Provide BUP file support for more issues.
  • Mark a large number of functions not used outside of the file as static.
  • Fix some spelling issues
  • Move UDFReadBlocksRaw declaration to dvdread_internal.h.
  • Inhibit double free of parental management information
  • Replaces the hard-coded values (in parental management)
  • Report which index failed reading

Fixes #9828. The ticket contained a patch which purports to fix additional memory leaks in the upstream copy, but I'm going to insist that that patch be applied upstream first for my sanity's sake. Given the slow rate of change in libdvdnav and libdvdread, I am willing to perform a resync when pinged on this after it's committed there.

Tested this resync with local, disc, and myth:// playback of ISOs and DVDs.

Branch: master
Changeset: bfdbc770533f718b5677c0d9e898325c0282dccf

comment:4 Changed 3 years ago by linux@…

Robert,

I will try to get my change to the fix applied upstream. In case it is applied, I think there is no need for an immediate resync as it is rather minor.

Thanks for the quick reaction!

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.