Opened 7 years ago
Closed 5 years ago
Last modified 5 years ago
#9833 closed Patch - Bug Fix (Fixed)
Date/Time mythweb session setting overridden by language specific defaults
Reported by: | Martin Bene <myth@…> | Owned by: | knight |
---|---|---|---|
Priority: | minor | Milestone: | 0.27 |
Component: | Plugin - MythWeb | Version: | 0.24-fixes |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Setting time format to "09:00/21:00" with english language does not work, times in listing view immediately revert to "09:00 AM / 09:00 pm" format.
The mythweb date/time format settings configurable in TV => My Session aren't actually used and get overwritten in the session object by language - dependant defaults.
Issue seems to be caused by mythweb/classes/Translate.php which unconditionaly updates the following session settings to the language specific default:
date_statusbar, date_scheduled, date_scheduled_popup, date_recorded, date_search, date_listing_key date_listing_jump, date_channel_jump, date_job_status time_format
a possible fix could be:
- only set these values in translate.php if the session object does not yet have a value for the setting
- delete the settings when changing the language
Attachments (1)
Change History (6)
Changed 7 years ago by Martin Bene <myth@…>
comment:1 Changed 5 years ago by knight
- Milestone changed from unknown to 0.27
- Owner changed from kormoc to knight
- Status changed from new to assigned
The code has changed (in part to address this problem) but applying part of this patch fixes the problem with the current code.
comment:2 Changed 5 years ago by Martin Bene <myth@…>
comment:3 Changed 5 years ago by Martin Bene <myth@…>
comment:4 Changed 5 years ago by Martin Bene <myth@…>
comment:5 Changed 5 years ago by knight
- Resolution set to Fixed
- Status changed from assigned to closed
The patch was applied to master, fixes/0.27 and fixes/0.26.
Thank you!
Nicolas
PS: The commit comment should have read like this "clears *the* sessions variables".
fix date/time format handling in mythweb