Modify ↓
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 7 months ago

Last modified 7 months ago

#9833 closed Patch - Bug Fix (Fixed)

Date/Time mythweb session setting overridden by language specific defaults

Reported by: Martin Bene <myth@…> Owned by: knight
Priority: minor Milestone: 0.27
Component: Plugin - MythWeb Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Setting time format to "09:00/21:00" with english language does not work, times in listing view immediately revert to "09:00 AM / 09:00 pm" format.

The mythweb date/time format settings configurable in TV => My Session aren't actually used and get overwritten in the session object by language - dependant defaults.

Issue seems to be caused by mythweb/classes/Translate.php which unconditionaly updates the following session settings to the language specific default:

date_statusbar, date_scheduled, date_scheduled_popup,
date_recorded, date_search, date_listing_key
date_listing_jump, date_channel_jump, date_job_status
time_format

a possible fix could be:

  • only set these values in translate.php if the session object does not yet have a value for the setting
  • delete the settings when changing the language

Attachments (1)

mythweb_timeformat_session.patch​ (3.8 KB) - added by Martin Bene <myth@…> 3 years ago.
fix date/time format handling in mythweb

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by Martin Bene <myth@…>

fix date/time format handling in mythweb

comment:1 Changed 7 months ago by knight

  • Milestone changed from unknown to 0.27
  • Owner changed from kormoc to knight
  • Status changed from new to assigned

The code has changed (in part to address this problem) but applying part of this patch fixes the problem with the current code.

comment:2 Changed 7 months ago by Martin Bene <myth@…>

In 0a25f1b95cf6a7eb7200f74bf16984d2d4949ae1/mythweb:

Fix MythWeb's date/time handling

The code in question has partially changed so I am applying part of Martin's patch
(the section that clears to session variables) to fix the problem.

Thank you Martin!

Refs #9833

Signed-off-by: Nicolas Riendeau <nriendeau@…>

comment:3 Changed 7 months ago by Martin Bene <myth@…>

In 014a23fc83a2dbb2e366d01ad8f524a209d3a72b/mythweb:

Fix MythWeb's date/time handling

The code in question has partially changed so I am applying part of Martin's patch
(the section that clears to session variables) to fix the problem.

Thank you Martin!

Refs #9833

Signed-off-by: Nicolas Riendeau <nriendeau@…>

comment:4 Changed 7 months ago by Martin Bene <myth@…>

In 33f0177459ded1ed3ca63c319bb825e3ee3a6d56/mythweb:

Fix MythWeb's date/time handling

The code in question has partially changed so I am applying part of Martin's patch
(the section that clears to session variables) to fix the problem.

Thank you Martin!

Refs #9833

Signed-off-by: Nicolas Riendeau <nriendeau@…>

comment:5 Changed 7 months ago by knight

  • Resolution set to Fixed
  • Status changed from assigned to closed

The patch was applied to master, fixes/0.27 and fixes/0.26.

Thank you!

Nicolas

PS: The commit comment should have read like this "clears *the* sessions variables".

Last edited 7 months ago by knight (previous) (diff)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.