Opened 8 years ago

Closed 8 years ago

#9873 closed Bug Report - General (fixed)

New mutlicast socket code breaks windows build

Reported by: markk Owned by: danielk
Priority: minor Milestone: 0.25
Component: Ports - Windows Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The main problem is that inet_pton is not available on MingW - and I'm not familiar enough with sockets to figure out a replacement.

The *nix only includes in mmulticastsocketdevice.h also need to be ifdef'd out for windows (as in mmulticastsocketdevice.cpp)

Attachments (1)

9873-v1.patch (830 bytes) - added by danielk 8 years ago.
replacement for inet_pton call

Download all attachments as: .zip

Change History (4)

comment:1 Changed 8 years ago by danielk

Milestone: unknown0.25
Status: newaccepted

Changed 8 years ago by danielk

Attachment: 9873-v1.patch added

replacement for inet_pton call

comment:2 Changed 8 years ago by danielk

I don't know why inet_pton isn't working, it should be according to this:

http://msdn.microsoft.com/en-us/library/cc805844%28v=vs.85%29.aspx

But it is unnecessary here, QHostAddress has the toIPv4Address() method for us.

Is this patch sufficient to fix windows compiles?

comment:3 Changed 8 years ago by Github

Resolution: fixed
Status: acceptedclosed

Fixes #9873. Minor header/api changes for Windows compile of multicast socket to succeed.

Branch: master Changeset: bd5dbc4b63bfd43c3d79d6260eebdae00c7ab446

Note: See TracTickets for help on using tickets.