Opened 14 years ago

Closed 13 years ago

#991 closed enhancement (invalid)

DPMS should wake up when media is inserted.

Reported by: kcodyjr@… Owned by: skamithi
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by danielk)

customEvent does not call gContext->ResetScreensaver?() for media insert events like it does for LIRC and joystick events; thus a user might insert a dvd, and hear the THX test track before realizing their monitor is still suspended. I've tested and confirmed this behavior. One-line fix.

Attachments (2)

myth-wake-on-media.patch (488 bytes) - added by kcodyjr@… 14 years ago.
myth-wake-on-media.2.patch (1.1 KB) - added by kcodyjr@… 14 years ago.
Fixed patch depends on trac #982.

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by kcodyjr@…

Attachment: myth-wake-on-media.patch added

comment:1 Changed 14 years ago by kcodyjr@…

FIRST PATCH IS BROKEN.

The wakeup event gets processed after xine exits. Not good enough.

Two approaches: directly call DoResetScreensaver?, or drop the processing event, and insert both the wakeup event and a copy of the event being dropped. I'm going with the simpler approach for now.

comment:2 Changed 14 years ago by kcodyjr@…

That approach didn't work. There is apparently some very asynchronous event handling happening.

This patch injects a wakeup event right before a copy of the event being processed, then returns without processing the event that triggered the processing. This effectively wakes up the monitor automatically when media is inserted.

A less naive patch might check to see that automatic media actions are enabled.

Changed 14 years ago by kcodyjr@…

Attachment: myth-wake-on-media.2.patch added

Fixed patch depends on trac #982.

comment:3 Changed 14 years ago by kcodyjr@…

The bug with DoResetScreensaver? was just a missing XSync() in screensaver-x11.cpp. Disregard the last inelegant patch; simpler (and effective) patch forthcoming.

Thanks to Chutt for the tip.

comment:4 Changed 14 years ago by kcodyjr@…

The XSync call has to go in code that is modified by my patch in #982. These changes will be incorporated in the next patch posted there.

comment:5 Changed 14 years ago by danielk

Description: modified (diff)
Milestone: 0.20
Type: defectpatch

comment:6 Changed 13 years ago by skamithi

Owner: changed from Isaac Richards to skamithi

comment:7 Changed 13 years ago by skamithi

hello kcodyr. this patch doesn't work for me. can you revise it to work with the latest svn revision.

comment:8 Changed 13 years ago by skamithi

Type: patchenhancement

comment:9 Changed 13 years ago by skamithi

Milestone: 0.20unknown
Version: head

comment:10 Changed 13 years ago by skamithi

Resolution: invalid
Status: newclosed

no response from patch provider. patch doesn't work with latest revision. closing the ticket.

Note: See TracTickets for help on using tickets.