Opened 8 years ago

Closed 8 years ago

#9913 closed Patch - Bug Fix (fixed)

ShellEscape should put double quotes around strings with a single quote

Reported by: Doug Haber <doug@…> Owned by:
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I was running mythmetadatalookup and it failed on a recording that had a subtitle of:
Tackin'

The reason was that it passed the following to the ttvdb.py script:

ttvdb.py -l en -N 90571 Tackin'

The command line was confused by the single quote. Attached is a simple patch that puts double quotes around strings with a single quote in them so that they look like:

ttvdb.py -l en -N 90571 "Tackin'"

I wasn't sure if always putting double quotes around strings would break anything else so I kept the patch as unintrusive as possible.

Thanks!

Doug

Attachments (1)

shellescape.diff (485 bytes) - added by Doug Haber <doug@…> 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by Doug Haber <doug@…>

Attachment: shellescape.diff added

comment:1 Changed 8 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: newclosed

Util: Escape single quotes.

Thanks to Doug Haber for the bug report, fixes #9913.

Branch: master Changeset: f4dbb71f4e974bc388d4c6f110e6936de9cf490b

Note: See TracTickets for help on using tickets.