Opened 18 years ago

Last modified 18 years ago

#991 closed enhancement

DPMS should wake up when media is inserted. — at Version 5

Reported by: kcodyjr@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by danielk)

customEvent does not call gContext->ResetScreensaver?() for media insert events like it does for LIRC and joystick events; thus a user might insert a dvd, and hear the THX test track before realizing their monitor is still suspended. I've tested and confirmed this behavior. One-line fix.

Change History (7)

Changed 18 years ago by kcodyjr@…

Attachment: myth-wake-on-media.patch added

comment:1 Changed 18 years ago by kcodyjr@…

FIRST PATCH IS BROKEN.

The wakeup event gets processed after xine exits. Not good enough.

Two approaches: directly call DoResetScreensaver?, or drop the processing event, and insert both the wakeup event and a copy of the event being dropped. I'm going with the simpler approach for now.

comment:2 Changed 18 years ago by kcodyjr@…

That approach didn't work. There is apparently some very asynchronous event handling happening.

This patch injects a wakeup event right before a copy of the event being processed, then returns without processing the event that triggered the processing. This effectively wakes up the monitor automatically when media is inserted.

A less naive patch might check to see that automatic media actions are enabled.

Changed 18 years ago by kcodyjr@…

Attachment: myth-wake-on-media.2.patch added

Fixed patch depends on trac #982.

comment:3 Changed 18 years ago by kcodyjr@…

The bug with DoResetScreensaver? was just a missing XSync() in screensaver-x11.cpp. Disregard the last inelegant patch; simpler (and effective) patch forthcoming.

Thanks to Chutt for the tip.

comment:4 Changed 18 years ago by kcodyjr@…

The XSync call has to go in code that is modified by my patch in #982. These changes will be incorporated in the next patch posted there.

comment:5 Changed 18 years ago by danielk

Description: modified (diff)
Milestone: 0.20
Type: defectpatch
Note: See TracTickets for help on using tickets.