Opened 10 years ago

Closed 10 years ago

#9974 closed Bug Report - General (fixed)

Windows compilation fixes after 47d67e6722092471069c52d1b0a37509477b5d85 and 6e37202bb8ffcbc35e62887a4cb9887afa5ab7e5

Reported by: Jonathan <jonathan@…> Owned by: Nigel
Priority: minor Milestone: 0.25
Component: Ports - Windows Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


It seems that the following commits brake compilation on windows:

47d67e6722092471069c52d1b0a37509477b5d85 removed pthread.h from jobqueue.h which is required (at least on windows)

6e37202bb8ffcbc35e62887a4cb9887afa5ab7e5 references m_file->name which is not a valid type for QString().arg(), I have replaced this with m_filename.

It makes the build go green on my local buildbot installation. :-)

Here is the pull request:

Change History (1)

comment:1 Changed 10 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: newclosed

Fix windows compilation

A couple minor issues.

Fixes #9974

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

Branch: master Changeset: f6598925e511c3484be24fc04b020a52bb506b43

Note: See TracTickets for help on using tickets.