Opened 8 years ago

Closed 8 years ago

#9985 closed Patch - Feature (fixed)

Duplicate Check enhancement

Reported by: lomion0815@… Owned by: gigem
Priority: minor Milestone: 0.25
Component: MythTV - Scheduling Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

For some channels in Germany and Austria (no Kangaroos) neither subtitle nor description match because EIT for the first broadcast of a epsidoe puts the episode name in the subtitle but the (late night) rerun has no subtitle instead the episode name was was put to the description field.

To work around this I do a "Check subtitle then description" including a check if subtitle an description is identical.

It works fine for me ...

Since I only run a 0.24-fixes the attached patch apply to the latest branch version

Attachments (3)

Enhanced_DupCheck.patch (3.6 KB) - added by lomion0815@… 8 years ago.
Enhanced_DupCheck_2.patch (3.3 KB) - added by lomion0815@… 8 years ago.
Clean-up of the code
Enhanced_DupCheck_3.patch (3.4 KB) - added by gigem 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by lomion0815@…

Attachment: Enhanced_DupCheck.patch added

comment:1 Changed 8 years ago by gigem

Status: newinfoneeded_new

lomion0815, please fix your patch to augment the existing kDupCheckSubThenDesc code in place and I will accept it. In one case, your current patch adds new code in a different location and leaves the old code unchanged. In another case, your patch adds new code in different location and comments out the old code.

Changed 8 years ago by lomion0815@…

Attachment: Enhanced_DupCheck_2.patch added

Clean-up of the code

comment:2 Changed 8 years ago by lomion0815@…

Cleaned up the code and attached a further patch

Changed 8 years ago by gigem

Attachment: Enhanced_DupCheck_3.patch added

comment:3 Changed 8 years ago by gigem

I still didn't like the reworked patch, so I did it myself in Enhanced_DupCheck_3.patch. Since the logic expressions are non-trivial, I'd like someone else to look them over before I commit them.

comment:4 Changed 8 years ago by lomion0815@…

Your improved patch does what I intended to achieve with my previous one and also my tests work as expected. So from my point of view your patch is correct.

comment:5 Changed 8 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: infoneeded_newclosed

Enhanced "Subtitle then Description" duplicate checking.

Some EIT providers reportedly put the subtitle in the description field in some situations. This change extends the "Subtitle then Description" logic to account for it. Based on a patch from lomion0815.

Fixes #9985.

Branch: master Changeset: a42bfc612f8ccd0b15bc2474ae27d53f33ba6dda

Note: See TracTickets for help on using tickets.