musicdbcheck.cpp

Go to the documentation of this file.

#include <QString>
#include <QDir>
#include <QSqlError>
 
#include <iostream>
 
#include <musicmetadata.h>
#include <mythcontext.h>
#include <mythdbcheck.h>
#include <mythtv/mythdb.h>
#include <mythtv/schemawizard.h>
 
#include "musicdbcheck.h"
 
const QString currentDatabaseVersion = "1025";
const QString MythMusicVersionName = "MusicDBSchemaVer";
 
static bool doUpgradeMusicDatabaseSchema(QString &dbver);
 
bool UpgradeMusicDatabaseSchema(void)
{
#ifdef IGNORE_SCHEMA_VER_MISMATCH
    return true;
#endif
    SchemaUpgradeWizard *schema_wizard = nullptr;
 
    // Suppress DB messages and turn of the settings cache,
    // These are likely to confuse the users and the code, respectively.
    GetMythDB()->SetSuppressDBMessages(true);
    gCoreContext->ActivateSettingsCache(false);
 
    // Get the schema upgrade lock
    MSqlQuery query(MSqlQuery::InitCon());
    bool locked = DBUtil::TryLockSchema(query, 1);
    for (uint i = 0; i < 2*60 && !locked; i++)
    {
        LOG(VB_GENERAL, LOG_INFO, "Waiting for database schema upgrade lock");
        locked = DBUtil::TryLockSchema(query, 1);
        if (locked)
            LOG(VB_GENERAL, LOG_INFO, "Got schema upgrade lock");
    }
    if (!locked)
    {
        LOG(VB_GENERAL, LOG_INFO, "Failed to get schema upgrade lock");
        goto upgrade_error_exit;
    }
 
    schema_wizard = SchemaUpgradeWizard::Get(
        "MusicDBSchemaVer", "MythMusic", currentDatabaseVersion);
 
    if (schema_wizard->Compare() == 0) // DB schema is what we need it to be..
        goto upgrade_ok_exit;
 
    if (schema_wizard->m_DBver.isEmpty())
    {
        // We need to create a database from scratch
        if (doUpgradeMusicDatabaseSchema(schema_wizard->m_DBver))
            goto upgrade_ok_exit;
        else
            goto upgrade_error_exit;
    }
 
    // Pop up messages, questions, warnings, et c.
    switch (schema_wizard->PromptForUpgrade("Music", true, false))
    {
        case MYTH_SCHEMA_USE_EXISTING:
            goto upgrade_ok_exit;
        case MYTH_SCHEMA_ERROR:
        case MYTH_SCHEMA_EXIT:
            goto upgrade_error_exit;
        case MYTH_SCHEMA_UPGRADE:
            break;
    }
 
    if (!doUpgradeMusicDatabaseSchema(schema_wizard->m_DBver))
    {
        LOG(VB_GENERAL, LOG_ERR, "Database schema upgrade failed.");
        goto upgrade_error_exit;
    }
 
    LOG(VB_GENERAL, LOG_INFO, "MythMusic database schema upgrade complete.");
 
    // On any exit we want to re-enable the DB messages so errors
    // are reported and we want to make sure the setting cache is
    // enabled for good performance and we must unlock the schema
    // lock. We use gotos with labels so it's impossible to miss
    // these steps.
  upgrade_ok_exit:
    GetMythDB()->SetSuppressDBMessages(false);
    gCoreContext->ActivateSettingsCache(true);
    if (locked)
        DBUtil::UnlockSchema(query);
    return true;
 
  upgrade_error_exit:
    GetMythDB()->SetSuppressDBMessages(false);
    gCoreContext->ActivateSettingsCache(true);
    if (locked)
        DBUtil::UnlockSchema(query);
    return false;
}
 
 
static bool doUpgradeMusicDatabaseSchema(QString &dbver)
{
    if (dbver.isEmpty())
    {
        LOG(VB_GENERAL, LOG_NOTICE,
            "Inserting MythMusic initial database information.");
 
        DBUpdates updates
        {
            "CREATE TABLE IF NOT EXISTS musicmetadata ("
            "    intid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    artist VARCHAR(128) NOT NULL,"
            "    album VARCHAR(128) NOT NULL,"
            "    title VARCHAR(128) NOT NULL,"
            "    genre VARCHAR(128) NOT NULL,"
            "    year INT UNSIGNED NOT NULL,"
            "    tracknum INT UNSIGNED NOT NULL,"
            "    length INT UNSIGNED NOT NULL,"
            "    filename TEXT NOT NULL,"
            "    rating INT UNSIGNED NOT NULL DEFAULT 5,"
            "    lastplay TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP "
            "                       ON UPDATE CURRENT_TIMESTAMP,"
            "    playcount INT UNSIGNED NOT NULL DEFAULT 0,"
            "    INDEX (artist),"
            "    INDEX (album),"
            "    INDEX (title),"
            "    INDEX (genre)"
            ");",
            "CREATE TABLE IF NOT EXISTS musicplaylist ("
            "    playlistid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    name VARCHAR(128) NOT NULL,"
            "    hostname VARCHAR(255),"
            "    songlist TEXT NOT NULL"
            ");"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1000", dbver))
            return false;
    }
 
    if (dbver == "1000")
    {
        QString startdir = gCoreContext->GetSetting("MusicLocation");
        startdir = QDir::cleanPath(startdir);
        if (!startdir.endsWith("/"))
            startdir += "/";
 
        MSqlQuery query(MSqlQuery::InitCon());
        // urls as filenames are NOT officially supported yet
        if (query.exec("SELECT filename, intid FROM musicmetadata WHERE "
                       "filename NOT LIKE ('%://%');"))
        {
            int i = 0;
            QString intid;
            QString name;
            QString newname;
 
            MSqlQuery modify(MSqlQuery::InitCon());
            while (query.next())
            {
                name = query.value(0).toString();
                newname = name;
                intid = query.value(1).toString();
 
                if (newname.startsWith(startdir))
                {
                    newname.remove(0, startdir.length());
                    if (modify.exec(QString("UPDATE musicmetadata SET "
                                    "filename = \"%1\" "
                                    "WHERE filename = \"%2\" AND intid = %3;")
                                    .arg(newname, name, intid)))
                        i += modify.numRowsAffected();
                }
            }
            LOG(VB_GENERAL, LOG_NOTICE,
                QString("Modified %1 entries for db schema 1001").arg(i));
        }
 
        if (!UpdateDBVersionNumber("MythMusic", MythMusicVersionName, "1001", dbver))
            return false;
    }
 
    if (dbver == "1001")
    {
        DBUpdates updates
        {
            "ALTER TABLE musicmetadata ADD mythdigest      VARCHAR(255);",
            "ALTER TABLE musicmetadata ADD size            BIGINT UNSIGNED;",
            "ALTER TABLE musicmetadata ADD date_added      DATETIME;",
            "ALTER TABLE musicmetadata ADD date_modified   DATETIME;",
            "ALTER TABLE musicmetadata ADD format          VARCHAR(4);",
            "ALTER TABLE musicmetadata ADD description     VARCHAR(255);",
            "ALTER TABLE musicmetadata ADD comment         VARCHAR(255);",
            "ALTER TABLE musicmetadata ADD compilation     TINYINT DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD composer        VARCHAR(255);",
            "ALTER TABLE musicmetadata ADD disc_count      SMALLINT UNSIGNED DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD disc_number     SMALLINT UNSIGNED DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD track_count     SMALLINT UNSIGNED DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD start_time      INT UNSIGNED DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD stop_time       INT UNSIGNED;",
            "ALTER TABLE musicmetadata ADD eq_preset       VARCHAR(255);",
            "ALTER TABLE musicmetadata ADD relative_volume TINYINT DEFAULT 0;",
            "ALTER TABLE musicmetadata ADD sample_rate     INT UNSIGNED;",
            "ALTER TABLE musicmetadata ADD bpm             SMALLINT UNSIGNED;",
            "ALTER TABLE musicmetadata ADD INDEX (mythdigest);"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1002", dbver))
            return false;
    }
 
    if (dbver == "1002")
    {
        LOG(VB_GENERAL, LOG_NOTICE,
            "Updating music metadata to be UTF-8 in the database");
 
        MSqlQuery query(MSqlQuery::InitCon());
        query.prepare("SELECT intid, artist, album, title, genre, "
                      "filename FROM musicmetadata ORDER BY intid;");
 
        if (query.exec() && query.isActive() && query.size() > 0)
        {
            while (query.next())
            {
                int id = query.value(0).toInt();
                QString artist = query.value(1).toString();
                QString album = query.value(2).toString();
                QString title = query.value(3).toString();
                QString genre = query.value(4).toString();
                QString filename = query.value(5).toString();
 
                MSqlQuery subquery(MSqlQuery::InitCon());
                subquery.prepare("UPDATE musicmetadata SET "
                                 "artist = :ARTIST, album = :ALBUM, "
                                 "title = :TITLE, genre = :GENRE, "
                                 "filename = :FILENAME "
                                 "WHERE intid = :ID;");
                subquery.bindValue(":ARTIST",   QString(artist.toUtf8()));
                subquery.bindValue(":ALBUM",    QString(album.toUtf8()));
                subquery.bindValue(":TITLE",    QString(title.toUtf8()));
                subquery.bindValue(":GENRE",    QString(genre.toUtf8()));
                subquery.bindValue(":FILENAME", QString(filename.toUtf8()));
                subquery.bindValue(":ID", id);
 
                if (!subquery.exec() || !subquery.isActive())
                    MythDB::DBError("music utf8 update", subquery);
            }
        }
 
        query.prepare("SELECT playlistid, name FROM musicplaylist "
                      "ORDER BY playlistid;");
 
        if (query.exec() && query.isActive() && query.size() > 0)
        {
            while (query.next())
            {
                int id = query.value(0).toInt();
                QString name = query.value(1).toString();
 
                MSqlQuery subquery(MSqlQuery::InitCon());
                subquery.prepare("UPDATE musicplaylist SET "
                                 "name = :NAME WHERE playlistid = :ID ;");
                subquery.bindValue(":NAME", QString(name.toUtf8()));
                subquery.bindValue(":ID", id);
 
                if (!subquery.exec() || !subquery.isActive())
                    MythDB::DBError("music playlist utf8 update", subquery);
            }
        }
 
        LOG(VB_GENERAL, LOG_NOTICE, "Done updating music metadata to UTF-8");
 
        if (!UpdateDBVersionNumber("MythMusic", MythMusicVersionName, "1003", dbver))
            return false;
    }
 
    if (dbver == "1003")
    {
        DBUpdates updates
        {
            "DROP TABLE IF EXISTS smartplaylistcategory;",
            "CREATE TABLE smartplaylistcategory ("
            "    categoryid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    name VARCHAR(128) NOT NULL,"
            "    INDEX (name)"
            ");",
 
            // NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
            "INSERT INTO smartplaylistcategory SET categoryid = 1, "
            "    name = \"Decades\";",
            "INSERT INTO smartplaylistcategory SET categoryid = 2, "
            "    name = \"Favourite Tracks\";",
            "INSERT INTO smartplaylistcategory SET categoryid = 3, "
            "    name = \"New Tracks\";",
 
            "DROP TABLE IF EXISTS smartplaylist;",
            "CREATE TABLE smartplaylist ("
            "    smartplaylistid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    name VARCHAR(128) NOT NULL,"
            "    categoryid INT UNSIGNED NOT NULL,"
            "    matchtype SET('All', 'Any') NOT NULL DEFAULT 'All',"
            "    orderby VARCHAR(128) NOT NULL DEFAULT '',"
            "    limitto INT UNSIGNED NOT NULL DEFAULT 0,"
            "    INDEX (name),"
            "    INDEX (categoryid)"
            ");",
            "DROP TABLE IF EXISTS smartplaylistitem;",
            "CREATE TABLE smartplaylistitem ("
            "    smartplaylistitemid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    smartplaylistid INT UNSIGNED NOT NULL,"
            "    field VARCHAR(50) NOT NULL,"
            "    operator VARCHAR(20) NOT NULL,"
            "    value1 VARCHAR(255) NOT NULL,"
            "    value2 VARCHAR(255) NOT NULL,"
            "    INDEX (smartplaylistid)"
            ");",
            "INSERT INTO smartplaylist SET smartplaylistid = 1, name = \"1960's\", "
            "    categoryid = 1, matchtype = \"All\", orderby = \"Artist (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 1, field = \"Year\","
            "    operator = \"is between\", value1 = \"1960\", value2 = \"1969\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 2, name = \"1970's\", "
            "    categoryid = 1, matchtype = \"All\", orderby = \"Artist (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 2, field = \"Year\","
            "    operator = \"is between\", value1 = \"1970\", value2 = \"1979\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 3, name = \"1980's\", "
            "    categoryid = 1, matchtype = \"All\", orderby = \"Artist (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 3, field = \"Year\","
            "    operator = \"is between\", value1 = \"1980\", value2 = \"1989\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 4, name = \"1990's\", "
            "    categoryid = 1, matchtype = \"All\", orderby = \"Artist (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 4, field = \"Year\","
            "    operator = \"is between\", value1 = \"1990\", value2 = \"1999\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 5, name = \"2000's\", "
            "    categoryid = 1, matchtype = \"All\", orderby = \"Artist (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 5, field = \"Year\","
            "    operator = \"is between\", value1 = \"2000\", value2 = \"2009\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 6, name = \"Favorite Tracks\", "
            "    categoryid = 2, matchtype = \"All\","
            "    orderby = \"Artist (A), Album (A)\", limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 6, field = \"Rating\","
            "    operator = \"is greater than\", value1 = \"7\", value2 = \"0\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 7, name = \"100 Most Played Tracks\", "
            "    categoryid = 2, matchtype = \"All\", orderby = \"Play Count (D)\","
            "    limitto = 100;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 7, field = \"Play Count\","
            "    operator = \"is greater than\", value1 = \"0\", value2 = \"0\";",
 
            "INSERT INTO smartplaylist SET smartplaylistid = 8, name = \"Never Played Tracks\", "
            "    categoryid = 3, matchtype = \"All\", orderby = \"Artist (A), Album (A)\","
            "    limitto = 0;",
            "INSERT INTO smartplaylistitem SET smartplaylistid = 8, field = \"Play Count\","
            "    operator = \"is equal to\", value1 = \"0\", value2 = \"0\";"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1004", dbver))
            return false;
    }
 
    if (dbver == "1004")
    {
        DBUpdates updates
        {
            "ALTER TABLE musicmetadata ADD compilation_artist VARCHAR(128) NOT NULL AFTER artist;",
            "ALTER TABLE musicmetadata ADD INDEX (compilation_artist);"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1005", dbver))
            return false;
    }
 
 
    if (dbver == "1005")
    {
        DBUpdates updates
        {
            "CREATE TABLE music_albums ("
            "    album_id int(11) unsigned NOT NULL auto_increment PRIMARY KEY,"
            "    artist_id int(11) unsigned NOT NULL default '0',"
            "    album_name varchar(255) NOT NULL default '',"
            "    year smallint(6) NOT NULL default '0',"
            "    compilation tinyint(1) unsigned NOT NULL default '0',"
            "    INDEX idx_album_name(album_name)"
            ");",
            "CREATE TABLE music_artists ("
            "    artist_id int(11) unsigned NOT NULL auto_increment PRIMARY KEY,"
            "    artist_name varchar(255) NOT NULL default '',"
            "    INDEX idx_artist_name(artist_name)"
            ");",
            "CREATE TABLE music_genres ("
            "    genre_id int(11) unsigned NOT NULL auto_increment PRIMARY KEY,"
            "    genre varchar(25) NOT NULL default '',"
            "    INDEX idx_genre(genre)"
            ");",
            "CREATE TABLE music_playlists ("
            "    playlist_id int(11) unsigned NOT NULL auto_increment PRIMARY KEY,"
            "    playlist_name varchar(255) NOT NULL default '',"
            "    playlist_songs text NOT NULL,"
            "    last_accessed timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP "
            "                            ON UPDATE CURRENT_TIMESTAMP,"
            "    length int(11) unsigned NOT NULL default '0',"
            "    songcount smallint(8) unsigned NOT NULL default '0',"
            "    hostname VARCHAR(255) NOT NULL default ''"
            ");",
            "CREATE TABLE music_songs ("
            "    song_id int(11) unsigned NOT NULL auto_increment PRIMARY KEY,"
            "    filename text NOT NULL,"
            "    name varchar(255) NOT NULL default '',"
            "    track smallint(6) unsigned NOT NULL default '0',"
            "    artist_id int(11) unsigned NOT NULL default '0',"
            "    album_id int(11) unsigned NOT NULL default '0',"
            "    genre_id int(11) unsigned NOT NULL default '0',"
            "    year smallint(6) NOT NULL default '0',"
            "    length int(11) unsigned NOT NULL default '0',"
            "    numplays int(11) unsigned NOT NULL default '0',"
            "    rating tinyint(4) unsigned NOT NULL default '0',"
            "    lastplay timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP "
            "                       ON UPDATE CURRENT_TIMESTAMP,"
            "    date_entered datetime default NULL,"
            "    date_modified datetime default NULL,"
            "    format varchar(4) NOT NULL default '0',"
            "    mythdigest VARCHAR(255),"
            "    size BIGINT(20) unsigned,"
            "    description VARCHAR(255),"
            "    comment VARCHAR(255),"
            "    disc_count SMALLINT(5) UNSIGNED DEFAULT '0',"
            "    disc_number SMALLINT(5) UNSIGNED DEFAULT '0',"
            "    track_count SMALLINT(5) UNSIGNED DEFAULT '0',"
            "    start_time INT(10) UNSIGNED DEFAULT '0',"
            "    stop_time INT(10) UNSIGNED,"
            "    eq_preset VARCHAR(255),"
            "    relative_volume TINYINT DEFAULT '0',"
            "    sample_rate INT(10) UNSIGNED DEFAULT '0',"
            "    bitrate INT(10) UNSIGNED DEFAULT '0',"
            "    bpm SMALLINT(5) UNSIGNED,"
            "    INDEX idx_name(name),"
            "    INDEX idx_mythdigest(mythdigest)"
            ");",
            "CREATE TABLE music_stats ("
            "    num_artists smallint(5) unsigned NOT NULL default '0',"
            "    num_albums smallint(5) unsigned NOT NULL default '0',"
            "    num_songs mediumint(8) unsigned NOT NULL default '0',"
            "    num_genres tinyint(3) unsigned NOT NULL default '0',"
            "    total_time varchar(12) NOT NULL default '0',"
            "    total_size varchar(10) NOT NULL default '0'"
            ");",
            "RENAME TABLE smartplaylist TO music_smartplaylists;",
            "RENAME TABLE smartplaylistitem TO music_smartplaylist_items;",
            "RENAME TABLE smartplaylistcategory TO music_smartplaylist_categories;",
            // Run necessary SQL to migrate the table structure
            // NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
            "CREATE TEMPORARY TABLE tmp_artists"
            "  SELECT DISTINCT artist FROM musicmetadata;",
            "INSERT INTO tmp_artists"
            "  SELECT DISTINCT compilation_artist"
            "  FROM musicmetadata"
            "  WHERE compilation_artist<>artist;",
            "INSERT INTO music_artists (artist_name) SELECT DISTINCT artist FROM tmp_artists;",
            "INSERT INTO music_albums (artist_id, album_name, year, compilation) "
            "  SELECT artist_id, album, ROUND(AVG(year)) AS year, IF(SUM(compilation),1,0) AS compilation"
            "  FROM musicmetadata"
            "  LEFT JOIN music_artists ON compilation_artist=artist_name"
            "  GROUP BY artist_id, album;",
            "INSERT INTO music_genres (genre) SELECT DISTINCT genre FROM musicmetadata;",
            "INSERT INTO music_songs "
            "   (song_id, artist_id, album_id, genre_id, year, lastplay,"
            "    date_entered, date_modified, name, track, length, size, numplays,"
            "    rating, filename)"
            "  SELECT intid, ma.artist_id, mb.album_id, mg.genre_id, mmd.year, lastplay,"
            "         date_added, date_modified, title, tracknum, length, IFNULL(size,0), playcount,"
            "         rating, filename"
            "  FROM musicmetadata AS mmd"
            "  LEFT JOIN music_artists AS ma ON mmd.artist=ma.artist_name"
            "  LEFT JOIN music_artists AS mc ON mmd.compilation_artist=mc.artist_name"
            "  LEFT JOIN music_albums AS mb ON mmd.album=mb.album_name AND mc.artist_id=mb.artist_id"
            "  LEFT JOIN music_genres AS mg ON mmd.genre=mg.genre;",
            "INSERT INTO music_playlists"
            "  (playlist_id,playlist_name,playlist_songs,hostname)"
            "  SELECT playlistid, name, songlist, hostname"
            "  FROM musicplaylist;",
            // Set all real playlists to be global by killing the hostname
            "UPDATE music_playlists"
            "  SET hostname=''"
            "  WHERE playlist_name<>'default_playlist_storage'"
            "    AND playlist_name<>'backup_playlist_storage';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1006", dbver))
            return false;
    }
 
    if (dbver == "1006")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_genres MODIFY genre VARCHAR(255) NOT NULL default '';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1007", dbver))
            return false;
    }
 
    if (dbver == "1007")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_songs MODIFY lastplay DATETIME DEFAULT NULL;",
            // NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
            "CREATE TABLE music_directories (directory_id int(20) NOT NULL AUTO_INCREMENT "
            "PRIMARY KEY, path TEXT NOT NULL, "
            "parent_id INT(20) NOT NULL DEFAULT '0') ;",
            "INSERT IGNORE INTO music_directories (path) SELECT DISTINCT"
            " SUBSTRING(filename FROM 1 FOR INSTR(filename, "
            "SUBSTRING_INDEX(filename, '/', -1))-2) FROM music_songs;",
            "CREATE TEMPORARY TABLE tmp_songs SELECT music_songs.*, directory_id "
            "FROM music_songs, music_directories WHERE "
            "music_directories.path=SUBSTRING(filename FROM 1 FOR "
            "INSTR(filename, SUBSTRING_INDEX(filename, '/', -1))-2);",
            "UPDATE tmp_songs SET filename=SUBSTRING_INDEX(filename, '/', -1);",
            "DELETE FROM music_songs;",
            "ALTER TABLE music_songs ADD COLUMN directory_id int(20) NOT NULL DEFAULT '0';",
            "INSERT INTO music_songs SELECT * FROM tmp_songs;",
            "ALTER TABLE music_songs ADD INDEX (directory_id);"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1008", dbver))
            return false;
    }
 
    if (dbver == "1008")
    {
        DBUpdates updates
        {
            "CREATE TABLE music_albumart (albumart_id int(20) NOT NULL AUTO_INCREMENT "
            "PRIMARY KEY, filename VARCHAR(255) NOT NULL DEFAULT '', directory_id INT(20) "
            "NOT NULL DEFAULT '0');"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1009", dbver))
            return false;
    }
 
    if (dbver == "1009")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_albumart ADD COLUMN imagetype tinyint(3) NOT NULL DEFAULT '0';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1010", dbver))
            return false;
 
        // scan though the music_albumart table and make a guess at what
        // each image represents from the filename
 
        LOG(VB_GENERAL, LOG_NOTICE, "Updating music_albumart image types");
 
        MSqlQuery query(MSqlQuery::InitCon());
        query.prepare("SELECT albumart_id, filename, directory_id, imagetype FROM music_albumart;");
 
        if (query.exec())
        {
            while (query.next())
            {
                int id = query.value(0).toInt();
                QString filename = query.value(1).toString();
                int directoryID = query.value(2).toInt();
                MSqlQuery subquery(MSqlQuery::InitCon());
 
                // guess the type from the filename
                int type = AlbumArtImages::guessImageType(filename);
 
                // if type is still unknown check to see how many images are available in the dir
                // and assume that if this is the only image it must be the front cover
                if (type == IT_UNKNOWN)
                {
                    subquery.prepare("SELECT count(directory_id) FROM music_albumart "
                                    "WHERE directory_id = :DIR;");
                    subquery.bindValue(":DIR", directoryID);
                    if (!subquery.exec() || !subquery.isActive())
                        MythDB::DBError("album art image count", subquery);
                    subquery.first();
                    if (query.value(0).toInt() == 1)
                        type = IT_FRONTCOVER;
                }
 
                // finally set the type in the music_albumart table
                subquery.prepare("UPDATE music_albumart "
                        "SET imagetype = :TYPE "
                        "WHERE albumart_id = :ID;");
                subquery.bindValue(":TYPE", type);
                subquery.bindValue(":ID", id);
                if (!subquery.exec() || !subquery.isActive())
                    MythDB::DBError("album art image type update", subquery);
            }
        }
    }
 
    if (dbver == "1010")
    {
        // update the VisualMode setting to the new format
        QString setting = gCoreContext->GetSetting("VisualMode");
        setting = setting.simplified();
        setting = setting.replace(' ', ";");
        gCoreContext->SaveSetting("VisualMode", setting);
 
        if (!UpdateDBVersionNumber("MythMusic", MythMusicVersionName, "1011", dbver))
            return false;
 
    }
 
    if (dbver == "1011")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_albumart ADD COLUMN song_id int(11) NOT NULL DEFAULT '0', "
            " ADD COLUMN embedded TINYINT(1) NOT NULL DEFAULT '0';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1012", dbver))
            return false;
 
    }
 
    if (dbver == "1012")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_songs ADD INDEX album_id (album_id);",
            "ALTER TABLE music_songs ADD INDEX genre_id (genre_id);",
            "ALTER TABLE music_songs ADD INDEX artist_id (artist_id);"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1013", dbver))
            return false;
 
    }
 
    if (dbver == "1013")
    {
        DBUpdates updates
        {
            "DROP TABLE musicmetadata;",
            "DROP TABLE musicplaylist;"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1014", dbver))
            return false;
    }
 
    if (dbver == "1014")
    {
        DBUpdates updates
        {
            qPrintable(QString("ALTER DATABASE %1 DEFAULT CHARACTER SET latin1;")
                       .arg(gContext->GetDatabaseParams().m_dbName)),
            // NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
            "ALTER TABLE music_albumart"
            "  MODIFY filename varbinary(255) NOT NULL default '';",
            "ALTER TABLE music_albums"
            "  MODIFY album_name varbinary(255) NOT NULL default '';",
            "ALTER TABLE music_artists"
            "  MODIFY artist_name varbinary(255) NOT NULL default '';",
            "ALTER TABLE music_directories"
            "  MODIFY path blob NOT NULL;",
            "ALTER TABLE music_genres"
            "  MODIFY genre varbinary(255) NOT NULL default '';",
            "ALTER TABLE music_playlists"
            "  MODIFY playlist_name varbinary(255) NOT NULL default '',"
            "  MODIFY playlist_songs blob NOT NULL,"
            "  MODIFY hostname varbinary(64) NOT NULL default '';",
            "ALTER TABLE music_smartplaylist_categories"
            "  MODIFY name varbinary(128) NOT NULL;",
            "ALTER TABLE music_smartplaylist_items"
            "  MODIFY field varbinary(50) NOT NULL,"
            "  MODIFY operator varbinary(20) NOT NULL,"
            "  MODIFY value1 varbinary(255) NOT NULL,"
            "  MODIFY value2 varbinary(255) NOT NULL;",
            "ALTER TABLE music_smartplaylists"
            "  MODIFY name varbinary(128) NOT NULL,"
            "  MODIFY orderby varbinary(128) NOT NULL default '';",
            "ALTER TABLE music_songs"
            "  MODIFY filename blob NOT NULL,"
            "  MODIFY name varbinary(255) NOT NULL default '',"
            "  MODIFY format varbinary(4) NOT NULL default '0',"
            "  MODIFY mythdigest varbinary(255) default NULL,"
            "  MODIFY description varbinary(255) default NULL,"
            "  MODIFY comment varbinary(255) default NULL,"
            "  MODIFY eq_preset varbinary(255) default NULL;",
            "ALTER TABLE music_stats"
            "  MODIFY total_time varbinary(12) NOT NULL default '0',"
            "  MODIFY total_size varbinary(10) NOT NULL default '0';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1015", dbver))
            return false;
    }
 
 
    if (dbver == "1015")
    {
        DBUpdates updates
        {
            qPrintable(QString("ALTER DATABASE %1 DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci;")
                    .arg(gContext->GetDatabaseParams().m_dbName)),
            // NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
            "ALTER TABLE music_albumart"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY filename varchar(255) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_albums"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY album_name varchar(255) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_artists"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY artist_name varchar(255) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_directories"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY path text CHARACTER SET utf8 NOT NULL;",
            "ALTER TABLE music_genres"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY genre varchar(255) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_playlists"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY playlist_name varchar(255) CHARACTER SET utf8 NOT NULL default '',"
            "  MODIFY playlist_songs text CHARACTER SET utf8 NOT NULL,"
            "  MODIFY hostname varchar(64) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_smartplaylist_categories"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY name varchar(128) CHARACTER SET utf8 NOT NULL;",
            "ALTER TABLE music_smartplaylist_items"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY field varchar(50) CHARACTER SET utf8 NOT NULL,"
            "  MODIFY operator varchar(20) CHARACTER SET utf8 NOT NULL,"
            "  MODIFY value1 varchar(255) CHARACTER SET utf8 NOT NULL,"
            "  MODIFY value2 varchar(255) CHARACTER SET utf8 NOT NULL;",
            "ALTER TABLE music_smartplaylists"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY name varchar(128) CHARACTER SET utf8 NOT NULL,"
            "  MODIFY orderby varchar(128) CHARACTER SET utf8 NOT NULL default '';",
            "ALTER TABLE music_songs"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY filename text CHARACTER SET utf8 NOT NULL,"
            "  MODIFY name varchar(255) CHARACTER SET utf8 NOT NULL default '',"
            "  MODIFY format varchar(4) CHARACTER SET utf8 NOT NULL default '0',"
            "  MODIFY mythdigest varchar(255) CHARACTER SET utf8 default NULL,"
            "  MODIFY description varchar(255) CHARACTER SET utf8 default NULL,"
            "  MODIFY comment varchar(255) CHARACTER SET utf8 default NULL,"
            "  MODIFY eq_preset varchar(255) CHARACTER SET utf8 default NULL;",
            "ALTER TABLE music_stats"
            "  DEFAULT CHARACTER SET utf8,"
            "  MODIFY total_time varchar(12) CHARACTER SET utf8 NOT NULL default '0',"
            "  MODIFY total_size varchar(10) CHARACTER SET utf8 NOT NULL default '0';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1016", dbver))
            return false;
    }
 
    if (dbver == "1016")
    {
        DBUpdates updates
        {
            "DELETE FROM keybindings "
            " WHERE action = 'DELETE' AND context = 'Music';"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1017", dbver))
            return false;
    }
 
    if (dbver == "1017")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_playlists MODIFY COLUMN last_accessed "
            "  TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP;"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1018", dbver))
            return false;
    }
 
    if (dbver == "1018")
    {
        DBUpdates updates
        {
            "CREATE TEMPORARY TABLE arttype_tmp ( type INT, name VARCHAR(30) );",
            "INSERT INTO arttype_tmp VALUES (0,'unknown'),(1,'front'),(2,'back'),(3,'cd'),(4,'inlay');",
            "UPDATE music_albumart LEFT JOIN arttype_tmp ON type = imagetype "
            "SET filename = CONCAT(song_id, '-', name, '.jpg') WHERE embedded=1;"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1019", dbver))
            return false;
    }
 
    if (dbver == "1019")
    {
        DBUpdates updates
        {
            "DROP TABLE IF EXISTS music_radios;",
            "CREATE TABLE music_radios ("
            "    intid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    station VARCHAR(128) NOT NULL,"
            "    channel VARCHAR(128) NOT NULL,"
            "    url VARCHAR(128) NOT NULL,"
            "    logourl VARCHAR(128) NOT NULL,"
            "    genre VARCHAR(128) NOT NULL,"
            "    metaformat VARCHAR(128) NOT NULL,"
            "    format VARCHAR(10) NOT NULL,"
            "    INDEX (station),"
            "    INDEX (channel)"
            ");"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1020", dbver))
            return false;
    }
 
    if (dbver == "1020")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_songs ADD COLUMN hostname VARCHAR(255) NOT NULL default '';",
            qPrintable(QString("UPDATE music_songs SET hostname = '%1';")
                       .arg(gCoreContext->GetMasterHostName()))
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1021", dbver))
            return false;
    }
 
    if (dbver == "1021")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_albumart ADD COLUMN hostname VARCHAR(255) NOT NULL default '';",
            qPrintable(QString("UPDATE music_albumart SET hostname = '%1';")
                       .arg(gCoreContext->GetMasterHostName()))
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1022", dbver))
            return false;
    }
 
    if (dbver == "1022")
    {
        DBUpdates updates
        {
            "CREATE INDEX `song_id` ON music_albumart (song_id);",
            "CREATE INDEX `artist_id` ON music_albums (artist_id);"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1023", dbver))
            return false;
    }
 
    if (dbver == "1023")
    {
        DBUpdates updates
        {
            "DROP INDEX station ON music_radios;",
            "ALTER TABLE music_radios CHANGE COLUMN station broadcaster VARCHAR(100) NOT NULL default '';",
            "ALTER TABLE music_radios MODIFY COLUMN channel VARCHAR(200) NOT NULL default '';",
            "ALTER TABLE music_radios ADD description TEXT NOT NULL default '' AFTER channel;",
            "ALTER TABLE music_radios CHANGE COLUMN url url1 VARCHAR(300) NOT NULL default '';",
            "ALTER TABLE music_radios ADD COLUMN url2 VARCHAR(300) NOT NULL default '' AFTER url1;",
            "ALTER TABLE music_radios ADD COLUMN url3 VARCHAR(300) NOT NULL default '' AFTER url2;",
            "ALTER TABLE music_radios ADD COLUMN url4 VARCHAR(300) NOT NULL default '' AFTER url3;",
            "ALTER TABLE music_radios ADD COLUMN url5 VARCHAR(300) NOT NULL default '' AFTER url4;",
            "ALTER TABLE music_radios MODIFY COLUMN logourl VARCHAR(300) NOT NULL default '';",
            "ALTER TABLE music_radios MODIFY COLUMN metaformat VARCHAR(50) NOT NULL default '';",
            "ALTER TABLE music_radios ADD COLUMN country VARCHAR(50) NOT NULL default '' AFTER logourl;",
            "ALTER TABLE music_radios ADD COLUMN language VARCHAR(50) NOT NULL default '' AFTER country;",
            "CREATE INDEX broadcaster ON music_radios (broadcaster);",
            "DROP TABLE IF EXISTS music_streams;",
            "CREATE TABLE music_streams ("
            "    intid INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,"
            "    broadcaster VARCHAR(100) NOT NULL default '',"
            "    channel VARCHAR(200) NOT NULL default '',"
            "    description TEXT NOT NULL default '',"
            "    url1 VARCHAR(300) NOT NULL default '',"
            "    url2 VARCHAR(300) NOT NULL default '',"
            "    url3 VARCHAR(300) NOT NULL default '',"
            "    url4 VARCHAR(300) NOT NULL default '',"
            "    url5 VARCHAR(300) NOT NULL default '',"
            "    logourl VARCHAR(300) NOT NULL default '',"
            "    genre VARCHAR(100) NOT NULL default '',"
            "    metaformat VARCHAR(50) NOT NULL default '',"
            "    country VARCHAR(50) NOT NULL default '',"
            "    language VARCHAR(50) NOT NULL default '',"
            "    INDEX (broadcaster),"
            "    INDEX (channel),"
            "    INDEX (country),"
            "    INDEX (language)"
            ");"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1024", dbver))
            return false;
    }
 
    // Repeat 1016 DBs pre MySQL v8 systems that may have not be set to utf8
 
    if (dbver == "1024")
    {
        DBUpdates updates
        {
            "ALTER TABLE music_albumart DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_albums DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_artists DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_directories DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_genres DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_playlists DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_smartplaylist_categories DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_smartplaylist_items DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_smartplaylists DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_songs DEFAULT CHARACTER SET utf8;",
            "ALTER TABLE music_stats DEFAULT CHARACTER SET utf8;"
        };
 
        if (!performActualUpdate("MythMusic", MythMusicVersionName,
                                 updates, "1025", dbver))
            return false;
    }
 
    return true;
 
}