Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#11136 closed Patch - Bug Fix (fixed)

[Patch] Fix build on big endian systems

Reported by: Craig Treleaven <ctreleaven@…> Owned by: JYA
Priority: minor Milestone: 0.27.2
Component: Ports - OSX Version: 0.25.2
Severity: medium Keywords: big endian PPC byteswap
Cc: Ticket locked: no

Description

Myth does not build on big endian systems such as PPC (OS X) as /libs/libmythtv tries to conditionally include the file byteswap.h that is no longer in Git. Attached patches put inline code in the two affected programs that allows the build to finish.

Attachments (3)

patch-mythtv-libs-libmythtv-avformatwriter.cpp.diff​ (635 bytes) - added by Craig Treleaven <ctreleaven@…> 12 years ago.
patch-mythtv-libs-libmythtv-NuppelVideoRecorder.cpp.diff​ (626 bytes) - added by Craig Treleaven <ctreleaven@…> 12 years ago.
mythtv-bswap.diff​ (634 bytes) - added by Chistian Marillat <marillat@…> 11 years ago.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by Craig Treleaven <ctreleaven@…>

Attachment: patch-mythtv-libs-libmythtv-avformatwriter.cpp.diff​ added

Changed 12 years ago by Craig Treleaven <ctreleaven@…>

Attachment: patch-mythtv-libs-libmythtv-NuppelVideoRecorder.cpp.diff​ added

comment:1 Changed 11 years ago by JYA

Status: new → infoneeded_new

is this still required?

comment:2 Changed 11 years ago by Jean-Yves Avenard <jyavenard@…>

Resolution: → fixed
Status: infoneeded_new → closed

In 0967877b0a71e15e6682b29171928524deb8bc7e/mythtv:

Fix build on big endian system

Fixes #11136

comment:3 Changed 11 years ago by Jean-Yves Avenard <jyavenard@…>

In 87152adc39ea8e15f1b67df4d80e55f03c718fd8/mythtv:

Fix build on big endian system

Fixes #11136

(cherry picked from commit 0967877b0a71e15e6682b29171928524deb8bc7e)

comment:5 Changed 11 years ago by JYA

Milestone: unknown → 0.27.2

comment:6 Changed 11 years ago by Jean-Yves Avenard <jyavenard@…>

In 1b56fcc29ab868b2f06ec7e0f8d02c01581daae5/mythtv:

Fix build on big endian system

Fixes #11136

comment:7 Changed 11 years ago by Jean-Yves Avenard <jyavenard@…>

In 4f4b6744637cceafd5ec6d82e24a9c34ba7c93b5/mythtv:

Fix build on big endian system

Fixes #11136

(cherry picked from commit 1b56fcc29ab868b2f06ec7e0f8d02c01581daae5)

comment:8 Changed 11 years ago by Chistian Marillat <marillat@…>

The fix in tis bug break build for Linux powerpc and sparc arches.

The best is to check if you build for OS X (with maybe MACOS) or Linux.

comment:9 Changed 11 years ago by JYA

Please provide compilation output and error.

Would be great if you could provide a shell access so I could try things... Or please provide a patch.

Changed 11 years ago by Chistian Marillat <marillat@…>

Attachment: mythtv-bswap.diff​ added

comment:10 Changed 11 years ago by Chistian Marillat <marillat@…>

Build log file (mythtv 0.27.2 Debian unstable powerpc)

​http://ping.esiee.fr/logs/mythtv-dmo_0.27.2-dmo1-powerpc-20140701-0252

Compile fine with the attached patch for i386 and sparc arches, mythtv 0.27.3, Debian unstable.

Basic patch attached. (I don't know if __MACOS__ is the rigth OS X macro).

Note: See TracTickets for help on using tickets.