Opened 18 years ago
Closed 18 years ago
#1193 closed patch (fixed)
Overscan: LiveTV OSD is Shifted Up and Left
| Reported by: | anonymous | Owned by: | danielk |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythtv | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I am using +5% horiz and vert overscan on Setup/Playback?. All of my OSD during LiveTV are shifted up and to the left a bit. For example, when I hit the "i" key to get to browse mode, the isthmus OSD usually fills the full picture from left to right and to the bottom of the screen. Lately (svn 8825 and a couple weeks prior), the OSD ends before it reaches the right and bottom edges.
Change History (9)
comment:1 Changed 18 years ago by
| Milestone: | → 0.20 |
|---|---|
| Summary: | LiveTV OSD is Shifted Up and Left → Overscan: LiveTV OSD is Shifted Up and Left |
comment:2 Changed 18 years ago by
comment:3 Changed 18 years ago by
I have the same problem. I'm not using overscan. And i have 640x480 resolution on a 4:3 TV. Not only LiveTV OSD it is in playback also, but i guess that is the same thing. Just thought i should mention that. Using svn 9080.
comment:4 Changed 18 years ago by
comment:5 Changed 18 years ago by
ATrpms' builds are not from the trunk, but from the -fixes branch. It's dangerous to compare on the revision alone.
comment:6 Changed 18 years ago by
| Owner: | changed from Isaac Richards to danielk |
|---|
comment:7 Changed 18 years ago by
| Milestone: | 0.20 → 0.21 |
|---|
comment:8 Changed 18 years ago by
| Type: | defect → patch |
|---|
A patch that fixes this problem is in #2162. Sorry I haven't checked the tickets if it's was reported earlier.
comment:9 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [10763]) Fixes #1193. Work around bug in Qt QRect(QPoint, QPoint) constructor properly.
Janne discovered that this Qt constuctor inexplicably adds 1 to the x and y of the lower right point. This removes the overscan hack we used before and uses a non-broken QRect constructor instead.
Removing the old hack fixes #1193 (OSD offset for large overscan values) and this makes the non-overscan case pixel exact so we don't lose the last column of the OSD when not using overscan.
related to #652?