Opened 8 years ago
Closed 8 years ago
Last modified 8 years ago
#12936 closed Patch - Bug Fix (fixed)
ffmpeg resync to 3.2: mythweb .flv streaming no more background loading in advance
| Reported by: | Owned by: | JYA | |
|---|---|---|---|
| Priority: | minor | Milestone: | 29.0 |
| Component: | 3rd Party - FFMPEG | Version: | Master Head |
| Severity: | medium | Keywords: | mythweb flv streaming |
| Cc: | Ticket locked: | no |
Description
This ffmpeg3.2 commit http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=5702416c57afb2bb062eb69d60fc42c31c91b674 effectively breaks content backgroung loading in advance on .flv players (i.e. flow player). Attached patch reverts mentioned ffmpeg commit and fixes issue.
Attachments (1)
Change History (9)
Changed 8 years ago by
comment:1 Changed 8 years ago by
| Component: | Plugin - MythWeb → 3rd Party - FFMPEG |
|---|---|
| Milestone: | unknown → 29.0 |
| Owner: | changed from Stuart Auchterlonie to JYA |
| Status: | new → assigned |
| Version: | Unspecified → Master Head |
comment:2 Changed 8 years ago by
| Status: | assigned → infoneeded |
|---|
if you have a fix for ffmpeg, please submit it upstream.
Having said that, I didn't even know we could generate on the fly flv stuff.
How do you call this.
Please produce steps to reproduce. As it is, I can't assess the severity of this problem, and if it's something we should fix too.
comment:4 Changed 8 years ago by
jya: to reproduce problem You can enable FLV streaming in mythweb (settings/mythweb/videoplayback) and try to watch any recording on mythweb. If You have fast backend able to encode faster than realtime, flash player on Your web browser should be downloading already encoded stream in background. You will see this in flow player progress bar (white bar is watched, light grey is downloaded in advance; light grey progresses much faster). I'm using this frequently as my backend i.e. can encode audio with 44..48x of realtime - so 1h audio is encoded within minutes. Having recording downloaded in by player allows me to freely skip any adverts just minute after starting listeninig. ffmpeg commit mentioned in this ticked breaks this functionality. With this errant ffmpeg commit, flow player is NOT showing background downloaded stream and not allows to freely walk on already downloaded content in flow player. In other words I can't skip adverts any more.
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | infoneeded → closed |
comment:7 follow-up: 8 Changed 8 years ago by
BTW, I don't see how the resync could have broken mythweb.
mythweb is directly calling the ffmpeg executable, nothing to do with what's the backend is compiled with.
comment:8 Changed 8 years ago by
Replying to jyavenard:
BTW, I don't see how the resync could have broken mythweb.
mythweb is directly calling the ffmpeg executable, nothing to do with what's the backend is compiled with.
https://github.com/MythTV/mythweb/blob/master/modules/stream/stream_flv.pl#L38
patch