Ticket #5911 (closed Patch - Bug Fix: fixed)
Opened 4 years ago
Last modified 9 months ago
mythmusic: Fix goom mmxext for amd64
| Reported by: | foobum@… | Owned by: | paulh |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.25 |
| Component: | Plugin - MythMusic | Version: | Unspecified |
| Severity: | low | Keywords: | goom amd64 |
| Cc: | Ticket locked: | no |
Description
The mmxext zoom filter in goom was disabled on amd64, presumably because it didn't compile. This small patch fixes the problem and enables the mmxext filter on amd64.
Attachments
Change History
comment:1 Changed 4 years ago by foobum@…
Turns out that the mmxext code is slower than the mmx on amd64. To make up for it, here's a SSE2 implementation that is ~ 10-20% faster than the mmx (on amd64). Not sure about ia32 - could someone test?
Also lowers the fps for goom a touch since it was excessively cpu hungry.
comment:2 Changed 4 years ago by foobum@…
New version - forgot to change .pro
comment:3 Changed 3 years ago by foobum@…
New version that combines the previous patches, improves the asm and makes it x86 compatible. Now significantly faster on am64 and ~ 33% faster (than the previous fastest method) on x86. Tested on both archs.
comment:5 Changed 2 years ago by danielk
- Owner changed from ijr to paulh
- Status changed from new to assigned
Paul, I've been told you are working on MythMusic...
comment:6 Changed 10 months ago by stuartm
- Version changed from unknown to Unspecified
- Type changed from patch to Patch - Bug Fix
- Milestone changed from unknown to 0.25
comment:7 Changed 9 months ago by Github
- Status changed from assigned to closed
- Resolution set to fixed
MythMusic: add faster zoom filter in goom that uses sse2 when available.
Fixes #5911.
Signed-off-by: Paul Harrison <pharrison@…>
Branch: master Changeset: c9fc987fe97590c0ce69905a43a3d63cd9ecb0e3
