Mythfrontend Memory Leak while watching BBC HD / BBC1 HD only

[sijones2010@…]

When watching BBC HD or BBC1 HD the frontend uses up memory causing the frontend to use all the memory up on the system, I have seen my own go to the region of 2Gb for frontend requiring a restart due to the system going slow and swapping to disk.

[sijones2010@…]

valgrind log of mythfrontend

[sijones2010@…]

valgind ran with

valgrind --leak-check=full --error-limit=no --show-reachable=yes

nvidia drivers version 260.19.29

[Stuart Auchterlonie]

From the valgrind logs it looks like it's in the subtitle handling.

Stuart

[v0466@…]

I noticed this problem a few weeks ago and tracked it down. I was intending to file a bug report but completely forgot about it (sorry).

I found two leaks. The first is in the subtitle handling code and is caused by a missing break statement in mythtv/external/FFmpeg/libavcodec/dvbsubdec.c after case DVBSUB_DISPLAYDEFINITION_SEGMENT.

The other leak is in mythtv/external/FFmpeg/libavformat/mpegts.c where it was reallocating a packet without freeing the old one. The fix is to add a call to av_free_packet().

I have been running with these two fixes for a few weeks and can watch BBC HD and BBC1 HD all day without running out of memory. I will attach patches shortly.

[v0466@…]

memory leak fix for dvbsubdec.c

[v0466@…]

memory leak fix for mpegts.c

[sphery]

In: af0f68e09e6311daee5a

Add missing break statement in dvbsubdec.c

Mea culpa - those are my mods to the dvb subtitle decoder.

mark-kendall (author)

[markk]

Fixed in af0f68e09e6311daee5a and 61c78f53245cbbaf6d15

If there is still an issue, please re-open.