Opened 8 years ago

Closed 6 years ago

#10042 closed Patch - Feature (Fixed)

mythburn.py enhancements

Reported by: Britney Fransen <britney.fransen@…> Owned by:
Priority: minor Milestone: 0.27
Component: Plugin - MythArchive Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached is a patch that improves mythburn.py aspect ratio and video storage groups support.

Changes:

  • getAspectRatioOfVideo: Changed streaminfo.xml to streaminfo_orig.xml. When ffmpeg transcodes the file the original DAR was lost. For example, 720x480 nuv files with a DAR of 1.33 after transcode the DAR would be 1.5 which would cause the aspect ratio of the output dvd to be set as 1.7778 causing the picture to be stretched.
  • Added getVideoPath: When using Storage Groups for videos an error would occur because mytharchivehelper only provides the filename and not the complete file path as it does for recordings. getVideoPath pulls the Videos storage groups paths from the db, adds the local videopath, and returns the path where the filename is found. getVideoPath replaces videopath in the rest of the script.
  • getStreamInformation: In many cases mytharchivehelper provides N/A for the aspect ratio or calculates the aspect ratio based on the PAR. In the patch getStreamInformation uses ffmpeg to get the DAR if it is available. If DAR isn't available it sets the aspect ratio from the PAR.
  • encodeVideoToMPEG2: In cases where the video aspect ratio is > 1.9 add padding to the ffmpeg output video to avoid stretched video. Added folder parameter.
  • encodeNuvToMPEG2: Removed the -crop* options as they do not work in the latest versions of ffmpeg or mythffmpeg that is in .24-fixes.
  • various other typos and whitespaces

Attachments (1)

mythburn.py.patch (12.7 KB) - added by Britney Fransen <britney.fransen@…> 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Britney Fransen <britney.fransen@…>

Attachment: mythburn.py.patch added

comment:1 Changed 8 years ago by paulh

Owner: paulh deleted
Status: newassigned

comment:2 Changed 6 years ago by Paul Harrison <pharrison@…>

In a3cf98c58828dfc0a42b58e2e303bcc1f02b1305/mythtv:

mythburn.py: remove the depreciated crop* options to mythffmpeg

The croptop, cropbottom, cropright and cropleft parameters are no longer
supported by mythffmeg so use the new -filter:v "crop=w:h:x:y"
parameter instead.

You would add something like this to your encoding profile

<parameter name="-filter:v" value="crop=640:480:100:100"/>

I don't have any nuv files so this is completely untested.

Refs #10042.

comment:3 Changed 6 years ago by Paul Harrison <pharrison@…>

In d177ff990b4d2d6715eff6964b6b4b7695702af3/mythtv:

mythburn.py: remove the depreciated crop* options to mythffmpeg

The croptop, cropbottom, cropright and cropleft parameters are no longer
supported by mythffmeg so use the new -filter:v "crop=w:h:x:y"
parameter instead.

You would add something like this to your encoding profile

<parameter name="-filter:v" value="crop=640:480:100:100"/>

I don't have any nuv files so this is completely untested.

Refs #10042.

(cherry picked from commit a3cf98c58828dfc0a42b58e2e303bcc1f02b1305)

comment:4 Changed 6 years ago by Paul Harrison <pharrison@…>

comment:5 Changed 6 years ago by Paul Harrison <pharrison@…>

In 19fcebc18ca029be57130af782b32e1258590fb2/mythtv:

mythburn.py: fix typo

Refs #10042.

(cherry picked from commit eaba998a1c9c126b65c3907b2d9db0cfa508ce40)

comment:6 Changed 6 years ago by paulh

Milestone: unknown0.27
Resolution: Fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.