Opened 13 years ago

Closed 2 years ago

#10045 closed Patch - Feature (Trac EOL)

Prevent looping in button list when less than three buttons

Reported by: Xavier Hervy <xavier.hervy@…> Owned by: stuartm
Priority: minor Milestone: needs_triage
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords: MythUIButtonList
Cc: xavier.hervy@… Ticket locked: no

Description

This patch intend to improve the usability of mythtv. Basically when the user reach the last/first element in a MythUIButtonList, MoveDown/MoveUp? select the first/last button in the list. This behaviour is fine when there is more than 2 items. However when there is only 2 items in the list It can be hard for the user to know which one is selected vs which one is not (theme dependant).

This patch disable this behaviour when there is less than 3 buttons. MoveDown/MoveUp? will stay on the last/first Button when the is less than 3 buttons in the list.

Attachments (2)

MythUIButtonList-noloop.diff.gz​ (352 bytes) - added by Xavier Hervy <xavier.hervy@…> 13 years ago.
MythUIButtonList-noloop-v2.diff.gz​ (546 bytes) - added by Xavier Hervy <xavier.hervy@…> 13 years ago.
Works for vertical list too

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Xavier Hervy <xavier.hervy@…>

Attachment: MythUIButtonList-noloop.diff.gz​ added

Changed 13 years ago by Xavier Hervy <xavier.hervy@…>

Attachment: MythUIButtonList-noloop-v2.diff.gz​ added

Works for vertical list too

comment:1 Changed 4 years ago by Stuart Auchterlonie

Milestone: unknown → needs_triage

Needs review

comment:2 Changed 2 years ago by Stuart Auchterlonie

Resolution: → Trac EOL
Status: new → closed

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - ​https://github.com/MythTV/mythtv/issues

Note: See TracTickets for help on using tickets.