Opened 7 years ago

Last modified 4 months ago

#10102 new Patch - Feature

EIT listener changes

Reported by: David Matthews <dm@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 29.2
Component: MythTV - EIT Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

This patch reworks the code that sets up listeners for EIT. While testing the EITpf timing code I found a problem when recording two programmes on the same multiplex and tracked it down to the way listeners are set up. This patch is almost completely independent of the EITpf timing patch (#10101) apart from one place in DVBStreamData::UpdateEITListeners where EIT listening is enabled if _dvb_eit_listeners.size() is non-zero.

The changes move responsibility for adding and removing listeners down from StreamHandler? to the derived classes of MPEGStreamData. I have tidied up the code for DVBStreamData but I've kept the changes to ATSCStreamData to a minimum because I couldn't test them.

The problem with the existing code was primarily that StreamHandler::UpdateListeningForEIT used the _eit_pids variable in StreamHandler? and updated it within the loop, using the new value for the next stream. That meant that EIT filtering could be on or off depending on the order of the streams in _stream_data_list. The fact that passive EIT scanning could be turned off during multirec recordings probably wouldn't make much difference since it is all statistical anyway.

David

Attachments (1)

eit-multirec.patch (15.8 KB) - added by David Matthews <dm@…> 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by David Matthews <dm@…>

Attachment: eit-multirec.patch added

comment:1 Changed 6 years ago by Stuart Auchterlonie

Milestone: unknown0.26
Version: UnspecifiedMaster Head

comment:2 Changed 6 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.27

comment:3 Changed 5 years ago by paulh

Milestone: 0.270.28

comment:4 Changed 2 years ago by Stuart Auchterlonie

Milestone: 0.280.29

comment:5 Changed 2 years ago by Stuart Auchterlonie

Milestone: 0.2929.0

Milestone renamed

comment:6 Changed 6 months ago by Stuart Auchterlonie

Milestone: 29.029.1

comment:7 Changed 4 months ago by Stuart Auchterlonie

Milestone: 29.10.28.2

Moving remaining open tickets to 0.28.2 milestone

comment:8 Changed 4 months ago by Stuart Auchterlonie

Milestone: 0.28.229.2

Moving remaining open tickets to 29.2 milestone

Note: See TracTickets for help on using tickets.