Opened 14 years ago
Closed 14 years ago
Last modified 13 years ago
#10120 closed Patch - Bug Fix (fixed)
PrePostRollFlagger results sometimes wrong
Reported by: | Owned by: | Raymond Wagner | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | MythTV - Mythcommflag | Version: | 0.24.1 |
Severity: | medium | Keywords: | commflag |
Cc: | Ticket locked: | no |
Description
I don't think I need to describe the symptoms with this patch, as it's clearly a copy/paste error!
In short, I sometimes end up with skiplists such as:
mysql> select mark,SEC_TO_TIME(mark/25) AS time,type,data from recordedmarkup where chanid=1002 and starttime ='2011-10-25 00:29:00' AND type IN (2,4,5) order by mark;
+-------+----------+------+------+ | mark | time | type | data | +-------+----------+------+------+ | 0 | 00:00:00 | 4 | NULL | | 1581 | 00:01:03 | 4 | NULL | | 98910 | 01:05:56 | 5 | NULL | +-------+----------+------+------+
(The start of the second break has been set to the end of the first one, overwriting it). After applying this patch and re-running commflag, I get more sensible results:
+-------+----------+------+------+ | mark | time | type | data | +-------+----------+------+------+ | 0 | 00:00:00 | 4 | NULL | | 1581 | 00:01:03 | 5 | NULL | | 91682 | 01:01:07 | 4 | NULL | | 98910 | 01:05:56 | 5 | NULL | +-------+----------+------+------+
Attachments (1)
Change History (6)
Changed 14 years ago by
Attachment: | mythcommflag.patch added |
---|
comment:1 Changed 14 years ago by
Owner: | changed from cpinkham to Raymond Wagner |
---|---|
Status: | new → accepted |
comment:2 Changed 14 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | accepted → closed |
comment:3 Changed 14 years ago by
Milestone: | 0.25 → 0.24.2 |
---|
Backported to 0.24
Branch: fixes/0.24 Changeset: fdfc989ebfe161fd58d977b38a4f2dd75aff1880
comment:4 Changed 14 years ago by
Thank you for the very fast apply, and for backporting into 0.24. This is what makes Free Software the best! :-)
Correct copy/paste error in postroll commercial detection
Corrects an incorrect variable use that was missed when copying a similar block of code added in 9f5ee51db82.
Fixes #10120 Refs #6889
Signed-off-by: Raymond Wagner <rwagner@…>