Opened 7 years ago

Closed 7 years ago

#10208 closed Patch - Bug Fix (fixed)

ISO-639 fixes (handle codes from the 14th edition and earlier and DVB-SI)

Reported by: dekarl@… Owned by: stuartm
Priority: trivial Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I stumbled upon upper case ISO-639 codes in the wild which will at least result in strange debugging (english name Unknown for code GER). While there I noticed that qaa (reserved for local use) is defined in EN 300 468 as "original language". According to some random website the upper case variant where valid ISO 639-2 codes until the 15th edition.

I hope this will help with automatic audio track selection etc. for stations that use the old codes. The patch is written to spec but untested as of now (still testing #10207) as the logfile didn't contain the channel of the PMT in question :(

Attachments (1)

0002-handle-more-ISO-639-codes.patch (1.9 KB) - added by dekarl@… 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by dekarl@…

comment:1 Changed 7 years ago by dekarl@…

here is an example from the logs that scrolled by just now (on channel21/rheinmaintv)

Feb 20 22:59:29 mythmaster mythbackend[14285]: CreatePMTSingleProgram()
Feb 20 22:59:29 mythmaster mythbackend[14285]: PMT in input stream
Feb 20 22:59:29 mythmaster mythbackend[14285]: Program Map Section
 PSIP tableID(0x2) length(46) extension(0x4b00)
      version(1) current(1) section(0) last_section(0)
      pnum(19200) pid(0xb00)
  Stream #0 pid(0xb07) type(0x06 private-data)
    Teletext Descriptor (0x56) length(5)
  Stream #1 pid(0xb01) type(0x02 video-mpeg2)
    Video Descriptor (0x02) length(3)
  Stream #2 pid(0xb02) type(0x03 audio-mp1-layer[1,2,3])
    ISO-639 Language: code(GER) canonical(GER) eng(Unknown)

comment:2 Changed 7 years ago by danielk

Owner: set to danielk
Status: newaccepted

comment:3 Changed 7 years ago by stuartm

Milestone: unknown0.25
Owner: changed from danielk to stuartm

comment:4 Changed 7 years ago by Github

Resolution: fixed
Status: acceptedclosed

Handle more ISO-639 codes

renames "qaa" to "original language" (see EN 300 468, DVB-SI) converts codes to lower case (supposedly switch from 14th to 15th edition of ISO 639)

Fixes #10208

Signed-off-by: Stuart Morgan <smorgan@…>

Branch: master Changeset: 6a200130eff435893bcd1d0c5df729dc24fcf12a

Note: See TracTickets for help on using tickets.