Modify mythlink.pl to allow relative file names to be used in the links

[Nick Martin <njm@…>]

This is useful if your links directory and recordings directory are both in a directory tree exported by an NFS server. Links to absolute file names will be broken in the NFS clients, but links to relative file names will be ok.

E.g., if /home is exported on an NFS server with the following dirs:

/home/nick/links
/home/mythtv/recordings

...and the exported /home is mounted by an NFS client at /mnt/mythtv, then

/mnt/mythtv/nick/links/Title.mpg -> /home/mythtv/recordings/1004_20111224115800.mpg is broken
/mnt/mythtv/nick/links/Title.mpg -> ../../mythtv/recordings/1004_20111224115800.mpg is ok

The attached patch adds a --relative option to allow relative file names to be used in the links created by mythlink.pl.

[mythtvorg@…]

There is a bug in this patch!

The added line:

$local_path = File::Spec->abs2rel($local_path, $dest);

Should be:

$local_path = File::Spec->abs2rel($local_path, $dirname);

Because $name may be of form "tv_show/episode" in which case the final directory will be attached to $name and missing from $dest.

Luckily, the existing code defines already: my $directory = dirname("$dest/$name");

[justpaul@…]

Replying to mythtvorg@…: The "should be":

$local_path = File::Spec->abs2rel($local_path, $dirname);

Should really be:

$local_path = File::Spec->abs2rel($local_path, $directory);

$dirname is undefined.

[mythtv@…]

You are absolutely right! For some reason, I typo'd when copying over the code...

[sphery]

Duplicate ticket/patch posted at #13115 . The implementation from the other ticket is at ​​https://github.com/MythTV/mythtv/pull/149 .

[Stuart Auchterlonie]

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - ​https://github.com/MythTV/mythtv/issues