Opened 8 years ago

Closed 7 years ago

#10341 closed Patch - Bug Fix (fixed)

Wrong default value for DB WOL retry

Reported by: xavier.hervy@… Owned by: danielk
Priority: minor Milestone: 0.26
Component: MythTV - Mythtv-setup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In mysql.txt, it is said that the default value is 5 when not specified but In the UI the default value is 0.

In the UI the number of retry is between 1 and 10 (also I don't know why It could not be 0)

There is few way to fix this:

  1. The easiest way is to replace line 894 of mythdb.cpp by:

params.wolRetry = settings.GetNumSetting?("WOLsqlConnectRetry",5);

  1. a better would be to load the default setting first and replace line 894 (and other similar one) by:

params.wolRetry = settings.GetNumSetting?("WOLsqlConnectRetry",params.wolRetry);

This patch implement the later

Attachments (1)

defaultDBsettingFix.diff (2.2 KB) - added by xavier.hervy@… 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by xavier.hervy@…

Attachment: defaultDBsettingFix.diff added

comment:1 Changed 8 years ago by danielk

Milestone: 0.250.26
Status: newaccepted

comment:2 Changed 7 years ago by Daniel Kristjansson <danielk@…>

Resolution: fixed
Status: acceptedclosed

In 986a5869911ca56d32ed3d6c0325f9e825e628c4/mythtv:

Fixes #10341. Use default SQLConnectRetry if not specified in the config.xml.

Reported by xavier.hervy@….

Note: See TracTickets for help on using tickets.