Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 19 months ago

#10393 closed Patch - Feature (fixed)

MythUISpinBox::AddSelection

Reported by: Xavier Hervy <xavier.hervy@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Allow to add special label for certain values.

This is used by the Frontend Settings UI, to associate label for some values.

Use case with PlayBack? group settings:

  • Skip ahead (seconds) with a range from 0 to 200, where 0 is the "Default" value (I suppose it will skip by and amount of second defined by on other setting)
  • Time stretch (speed x 100) with a range from 45 to 200, a special value "Default" (value = 0) is added (I suppose it will use the default time stretch defined by on other setting)

Attachments (1)

mythuispinbox.diff (1.8 KB) - added by Xavier Hervy <xavier.hervy@…> 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by Xavier Hervy <xavier.hervy@…>

comment:1 Changed 2 years ago by Xavier Hervy <xavier.hervy@…>

Sorry I incorrectly fill the ticket, it is suppose to be a new feature for MythUI

comment:2 Changed 2 years ago by paulh

  • Component changed from MythTV - General to MythTV - User Interface Library
  • Owner set to stuartm
  • Status changed from new to assigned
  • Version changed from Unspecified to Master Head

Stuart, I assume you would want to look at this

comment:3 Changed 2 years ago by stuartm

  • Type changed from Bug Report - General to Patch - Feature

comment:4 Changed 19 months ago by stuartm

  • Milestone changed from unknown to 0.27
  • Status changed from assigned to accepted

Xavier, I like this and I have been meaning to implement something similar for a long time. The only thing which is troubling me is the substitution of a label for the default/special value. It would look good, and clearly there is a need for any special values to be given a label to explain their meaning, but from a theme perspective spinboxes would have to become much wider to accommodate that label - Default is more than twice as wide as 200, and translations even more so (e.g. Spanish is 'Por defecto'). This ultimately spoil some effects, leaving spinboxes appearing too wide when showing values such as '1' and making something like that shown in this image impossible - http://miffteevee.co.uk/imagebin/spinbox_concept.png

I can't think of a way to avoid that though and it's not exactly a problem with the patch so much as the code that uses it.

comment:5 Changed 19 months ago by Xavier Hervy <xavier.hervy@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In a1a6877f8763be8f6fcefc26981b154cd8e23e4b/mythtv:

Allow special or default values in Spinboxes outside their normal range and display an optional label. Fixes #10393

Signed-off-by: Stuart Morgan <smorgan@…>

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.