Film artwork shown for recordings where rule defines series artwork

[stuartm]

I have two or three recording rules where it's set to use the TV series artwork, a series/episode is set even if they are just 1/1. However it's still downloading and displaying the artwork from tmdb.com for that inetref.

e.g. Where the rule set to use '74608' from tvdb (​http://thetvdb.com/?tab=series&id=74608&lid=7), the recording is showing artwork for '74608' from tmdb (​http://www.themoviedb.org/movie/74608).

The recording itself has series 0, episode 0, setting either of those to non-zero causes it to use the right artwork as expected. So the problem seems to be that even if the series/episode id of the recording rule is non-zero, it's not passed on to the recording.

[robertm]

I have a fix for this but am not permitted to make it since it requires a schema change. Sorry, this will not be fixed until at least .26.

[Github]

Prevent showing 0x0 artwork when a recording doesn't have Seas/Ep?.

I am not sure why this solution didn't occur to me earlier,

Basically, if the season input to the methods is 0, just order the season results descending. That way if the user has set artwork (or any artwork has been set for anything > 1x01), it'll be shown in higher priority than the 0x0 artwork.

The bug still exists (it's just inverted now, you'd get TV results if you actually had TV and movies with the same legit inetref, but this should affect far, far, far fewer people. Many/most users will probably never see this inversion of the bug at all.

Refs #10408

Branch: master Changeset: cbd97031538468035d8d8090dbe60108e941eb2e