Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#10496 closed Patch - Bug Fix (fixed)

fix "PESPacket: Failed CRC check 0xVARIABLE != 0xCONSTANT for StreamID = 0x70", part 2

Reported by: dekarl@… Owned by: danielk
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

part 2 of #10207 continue the refactor of PESPacket and PSIPTable to get the correct HasCRC implementation called at various locations

CAUTION: It compiles, records, but still emits CRC errors. I need to see whether they are from real reception problems (got some) or real driver issues (got some i2c locking issues which leads to lots packets on one frontend when the other frontend tunes a channel) or if there is a bug somewhere in the refactor.

Attachments (1)

0004-refactor-PESPacket-and-PSIPTable-some-more-to-silenc.patch​ (12.1 KB) - added by dekarl@… 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dekarl@…

Attachment: 0004-refactor-PESPacket-and-PSIPTable-some-more-to-silenc.patch​ added

comment:1 Changed 6 years ago by danielk

Owner: set to danielk
Status: new → accepted

See also #10495.

comment:2 Changed 5 years ago by Karl Dietz <dekarl@…>

In 08e471c7e102d6b284a408bea255dbb221253cff/mythtv:

add unit test for TimeDateTable?

Refs #10496

comment:3 Changed 5 years ago by Karl Dietz <dekarl@…>

Resolution: → fixed
Status: accepted → closed

In 20291e6ea1c76f861f1da63fc48afb2364dbc96c/mythtv:

don't force SI sections into a PESPacket, use the new constructor instead

A variant of this has been lightly tested and I'd like to get it into 0.27
as it should fix all kinds of issues down the line.

E.g. stuff related to the SI for DVB-CAM being rejected due to expecting
a CRC which they don't have

It also removes the false positive CRC errors from the logs.

Fixes #10495
Fixes #10496

comment:4 Changed 5 years ago by Raymond Wagner

Milestone: unknown → 0.27

comment:5 Changed 5 years ago by Karl Dietz <dekarl@…>

In 4751533355780c46ef09c2f952bf544c234f4d42/mythtv:

refactor PESPacket and PSIPTable some more to silence CRC errors

Refs #10495
Refs #10496

Note: See TracTickets for help on using tickets.