Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 10 months ago

Last modified 10 months ago

#10659 closed Bug Report - General (fixed)

mfdb put icons from xmltv grabbers into local storage instead of the SG

Reported by: dekarl@… Owned by: cpinkham
Priority: minor Milestone: 0.27
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

mythfilldatabase was not converted to store the channel icons in the storage group in [cda7871]

The database update should just store the filename instead of the absolute path in IconData::Save in mythtv/programs/mythfilldatabase/icondata.cpp
https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythfilldatabase/icondata.cpp#L291

MSqlQuery update(MSqlQuery::InitCon());
update.prepare(
    "UPDATE channel SET icon = :ICON "
    "WHERE chanid = :CHANID");

update.bindValue(":ICON", fi.filename);
update.bindValue(":CHANID", fi.chanid);

fi.filename is the absolute path where the icon gets stored. Its the same location where the storage group points to.

the Qt API suggests that this might strip the directory off the filename

update.bindValue(":ICON", QFileInfo(fi.filename).fileName());

notice the subtle difference between http://qt-project.org/doc/qt-4.8/qfile.html#fileName and http://qt-project.org/doc/qt-4.8/qfileinfo.html#fileName

Attachments (0)

Change History (4)

comment:1 Changed 2 years ago by dekarl@…

Looking further into it, now that I'm at home I notice the following.

The SG is named "ChannelIcons?" in the definition but the lookup goes to "ChannelIcon?" without "s" in many places (see [cda7871])
In limited testing on master, from some days ago, both mfdb and setup write the absolute path instead of just the filename into the "icon" column of the "channel" table.

comment:2 Changed 10 months ago by Chris Pinkham <cpinkham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 93275c77b157e2287291c4d96cb7bee6370da18e/mythtv:

Channel Icon fixes

  • Store Channel Icon filenames in the DB without directory info. This change affects both mythfilldatabase and mythtv-setup.

Fixes #10659.

  • Fix a channel icon editor refresh issue where the newly downloaded icon would not be displayed in the buttonlist if the icon was downloaded automatically without the user having to select an icon from the list.

comment:3 Changed 10 months ago by cpinkham

  • Milestone changed from unknown to 0.27

comment:4 Changed 10 months ago by cpinkham

  • Owner changed from stuartm to cpinkham

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.