Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10683 closed Bug Report - General (fixed)

mythfilldatabase mixing up additional parameters

Reported by: jan@… Owned by: wagnerrp
Priority: minor Milestone: 0.25.1
Component: MythTV - Mythfilldatabase Version: 0.25-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Something broke in the way mythfilldatabase is called when providing additional grabber parameters. I noticed that you had to prefix grabber parameters with " -- " after upgrading to 0.25, and this worked just fine after updating the configuration. But since a few days, this doesn't work anymore. The command line generated for example looks like:

mythfilldatabase -v xmltv --days 20 --verbose general --loglevel info --syslog local7

when it should be:

mythfilldatabase -v xmltv --verbose general --loglevel info --syslog local7 --  --days 20

Attachments (0)

Change History (8)

comment:1 Changed 2 years ago by stuartm

  • Owner changed from stuartm to wagnerrp
  • Status changed from new to assigned

For the record which grabber are you using? Usually it should be unnecessary to pass any additional arguments to the grabber, we should run mythfilldatabase automatically with the correct arguments - no user intervention/configuration required. Although not directly related to fixing this bug it would be nice to understand why you're finding it necessary to pass that argument and maybe we can work with the grabber author to make it unnecessary.

comment:2 Changed 2 years ago by dekarl@…

I can not think of any use case where specifying "--days 20" is the correct solution.

If your intention is to refresh all days on every day you should pass something like "--refresh 0-99" instead of "--days 20" to mythfilldatabase. (refreshing to 99 would call the grabber once for every day until it doesnt return any programming for a day)

Be careful with starting at "0"/today as that might change the programme of currently running recordings and give some weird effects. Better start at "1".

Another option would be for the grabber to specify that it prefers to have all days grabbed at once which MythTV will respect and change its grabbing behaviour.

comment:3 Changed 2 years ago by Gavin Hurlbut <ghurlbut@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 4ba7c3d447411da3cb34c34ca978b8f2e6f5fae0/mythtv:

Make mythfilldatabase calls put user-provided args last

Fixes #10683

comment:4 Changed 2 years ago by Gavin Hurlbut <ghurlbut@…>

In 2a2af9f7f7b66c13b7cb4e65149acbf6088f4cbf/mythtv:

Make mythfilldatabase calls put user-provided args last

Fixes #10683
(cherry picked from commit 4ba7c3d447411da3cb34c34ca978b8f2e6f5fae0)

comment:5 Changed 2 years ago by beirdo

  • Milestone changed from unknown to 0.25.1

comment:6 Changed 2 years ago by jan@…

The grabber that kind of requires this is eu_epgdata, which I am the maintainer for myself now. The problem with this grabber is that requests are limited per day. We cannot simply have MythTV request each day individually because this would too quickly exceed the request limit.

comment:7 Changed 2 years ago by stuartm

It sounds like you might want to modify the grabber to specify the 'allatonce' preference?

comment:8 Changed 2 years ago by mdean

Jan, please see http://irc.mythtv.org/ircLog/channel/1/2012-05-02:20:54:51/2012-05-02:20:59:37 (and talk with Karl Dietz if you have questions about the XMLTV suggestions).

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.