Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10705 closed Bug Report - General (fixed)

Spurious "Response too short" messages

Reported by: Ian Dall <ian@…> Owned by: sphery
Priority: minor Milestone: 0.25.1
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

PlaybackSock::GetMaxBitrate() expects 2 tokens in the reply but only one is sent. This error also results in a default value being used for max bitrate instead of the value reported by the slave backend.

Attachments (1)

get_max_bitrate.diff (616 bytes) - added by Ian Dall <ian@…> 8 years ago.
Patch to expect correct response from GET_MAX_BITRATE

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Ian Dall <ian@…>

Attachment: get_max_bitrate.diff added

Patch to expect correct response from GET_MAX_BITRATE

comment:1 Changed 8 years ago by sphery

In 69118953b:

Fix PlaybackSock::GetMaxBitrate? protocol usage.

QUERY_REMOTEENCODER now returns only one value. This change was missed when the protocol was changed to send 64-bit values directly, instead of encoded as two 32-bit ints (this part, specifically, in 1508085eb3 ).

comment:2 Changed 8 years ago by Ian Dall <ian@…>

Owner: set to Ian Dall <ian@…>
Resolution: fixed
Status: newclosed

In 5c56d5bc4ddc44b04265cabb8048878833ad3eaf/mythtv:

Fix PlaybackSock::GetMaxBitrate? protocol usage.

QUERY_REMOTEENCODER now returns only one value. This change was missed
when the protocol was changed to send 64-bit values directly, instead of
encoded as two 32-bit ints (this part, specifically, in 1508085eb3 ).

Fixes #10705.

Signed-off-by: Michael T. Dean <mdean@…>

comment:3 Changed 8 years ago by sphery

Milestone: unknown0.25.1

Thanks for the patch, Ian!

comment:4 Changed 8 years ago by Kenni Lund [kenni a kelu dot dk]

Owner: changed from Ian Dall <ian@…> to sphery
Note: See TracTickets for help on using tickets.