Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#10758 closed Patch - Bug Fix (fixed)

[PATCH] Mytharchive: Catch StopIteration exception in mythburn.py

Reported by: Lawrence Rust <lvr@…> Owned by: Lawrence Rust <lvr@…>
Priority: minor Milestone: 0.27
Component: Plugin - MythArchive Version: 0.25-fixes
Severity: medium Keywords: StopIteration exception
Cc: Ticket locked: no

Description

If a DVD is created from a single mpeg video then mythburn.py attempts to transcode the file to eliminate errors. However, runMythtranscode calls DB.searchRecorded to obtain the cutlist with an invalid chanid and starttime which results in a StopIteration? exception.

This patch catches the exception and returns an empty cutlist.

NB After applying this patch further errors are encountered later on in mythburn.py when running mplex, which reports that the file produced by mythreplex is unreadable, mythburn.log attached

Attachments (2)

mythburn.log​ (95.7 KB) - added by Lawrence Rust <lvr@…> 12 years ago.
0001-Mytharchive-Catch-StopIteration-exception-in-mythbur.patch​ (1.7 KB) - added by Lawrence Rust <lvr@…> 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Lawrence Rust <lvr@…>

Attachment: mythburn.log​ added

Changed 12 years ago by Lawrence Rust <lvr@…>

Attachment: 0001-Mytharchive-Catch-StopIteration-exception-in-mythbur.patch​ added

comment:1 Changed 12 years ago by J.Pilk@…

mythburn.log shows that mythtranscode failed with many stream discontinuities, probably soon after being called. The patch looks as if it's doing something worthwhile, but IMHO no-one should spend time trying to 'solve' the other problems by making changes within MythArchive?.

comment:2 Changed 11 years ago by Lawrence Rust <lvr@…>

Owner: set to Lawrence Rust <lvr@…>
Resolution: → fixed
Status: new → closed

In 19aaf86936c118a4241f03a0377da31dfdeba4fd/mythtv:

MythArchive?: Catch StopIteration? exception in mythburn.py

If a DVD is created from a single mpeg video then mythburn.py attempts
to transcode the file to eliminate any errors. However, runMythtranscode
calls DB.searchRecorded, to obtain any cutlist, with an invalid chanid
and starttime which results in a StopIteration? exception.

This patch catches the exception and returns an empty cutlist.

Fixes #10758.

Signed-off-by: Paul Harrison <pharrison@…>

comment:3 Changed 11 years ago by Raymond Wagner

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.