Opened 12 years ago
Closed 11 years ago
#10773 closed Patch - Bug Fix (fixed)
backend uses an invalid bonjour service type name
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - General | Version: | 0.25-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The backend advertises itself as supplying "mythbackend-master" or "mythbackend-slave" service but according to the relevant spec service names are limited to 14 characters (http://www.rfc-editor.org/rfc/rfc6335.txt section 5.1).
The patch changes the service to be "mythbackend" and adds a txt record containing either level='master' or level='slave'.
Guidance for format of the txt record is at http://files.dns-sd.org/draft-cheshire-dnsext-dns-sd.txt in section 6.
Attachments (3)
Change History (9)
Changed 12 years ago by
| Attachment: | bonjour-correction.patch added |
|---|
comment:1 Changed 12 years ago by
| Owner: | set to JYA |
|---|---|
| Status: | new → assigned |
| Version: | Unspecified → 0.25-fixes |
comment:2 Changed 11 years ago by
Changed 11 years ago by
| Attachment: | 0005-publish-under-long-and-short-bonjour-service-names.patch added |
|---|
broadcast long & short service names for packagers who wish to be compatible with all clients
Changed 11 years ago by
| Attachment: | 0006-Use-myth-bonjour-object.patch added |
|---|
update for recent code changes
comment:3 Changed 11 years ago by
| Milestone: | unknown → 0.27 |
|---|---|
| Owner: | changed from JYA to stuartm |
| Status: | assigned → accepted |
comment:4 Changed 11 years ago by
The Bonjour documentation indicates a limit of 63 characters for the service name, which is a vast difference from 15 (it's 15 not 14 in that RFC).
Accepting that we need to stick to that 15 char limit that means breaking compatibility with existing clients and if that has to happen, it might as well be in a major release instead of a point release. So I'm inclined to go with your first patch George.
comment:5 Changed 11 years ago by
So I'm inclined to go with your first patch George.
Thanks. The one change I'd make to that patch is to ditch the goofy "level=master" or "level=slave" bit and just go with a bareword "master" or "slave" in the txt record. After sending in the patch I remembered the convention about how a word on its own implies "=1".
My dual advertisment approach doesn't work anymore. JYA fixed some crashing related to bonjour and after that attempting a second broadcast would hang the server. I didn't look into it.
comment:6 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
This is impacting a program I am working on as well. Is this patch going to be applied?