Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 21 months ago

Closed 13 months ago

Last modified 13 months ago

#10932 closed Patch - Feature (fixed)

[PATCH] Add "apple-touch-icon" to MythWeb

Reported by: Joe Nyland <joe@…> Owned by: kormoc
Priority: minor Milestone: 0.27
Component: Plugin - MythWeb Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I'm attaching a patch for MythWeb to add an "apple-touch-icon" for iOS devices.

This basically links to a .png file, which is requested when an iOS user adds MythWeb as a favourite on their home screen. Currently, if an iOS user adds MythWeb to their iOS home screen, they get an ugly, unhelpful screen shot of the MythWeb interface (which is the default iOS behaviour when an apple-touch-icon cannot be found for the site which you are bookmarking). More info "apple-touch-icon"s is here.

With my patch, iOS will display a nice clear MythTV icon on a user's home screen when MythWeb is saved as a favourite there.

The other part of the feature addition involves adding three .png files to the img folders for each of the skins which are included in the repo. Unfortunately, I have very little experience with git and I am not a developer. I have spent a considerable amount of time today trying to figure out for myself a way to create a patch which includes the addition of these binary files cleanly. If there's a way in which this type of patch is generated, I'd really appreciate some pointers on how I can generate a patch for this.

For now, I'm attaching a patch for the header.php files which links to the .png images and I'll also attach a tarball containing the .png images themselves. These .png images simply need to be added to the img folder for each skin, e.g

skins/<skin_name>/img/apple-touch-icon.png
skins/<skin_name>/img/apple-touch-icon-72x72.png
skins/<skin_name>/img/apple-touch-icon-114x114.png

Attachments (2)

header.php.patch (2.0 KB) - added by Joe Nyland <joe@…> 21 months ago.
header.php patch file.
apple-touch-icons.tar.bz2 (26.7 KB) - added by Joe Nyland <joe@…> 21 months ago.
apple-touch-icon.png tarball.

Download all attachments as: .zip

Change History (4)

Changed 21 months ago by Joe Nyland <joe@…>

header.php patch file.

Changed 21 months ago by Joe Nyland <joe@…>

apple-touch-icon.png tarball.

comment:1 Changed 13 months ago by Rob Smith <kormoc@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 2a24fa110e2c353680c7eb9221c46c83ac7cd5a8/mythweb:

Fixes #10932, this adds in apple touch icons for the templates

comment:2 Changed 13 months ago by wagnerrp

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.