Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 21 months ago

Closed 21 months ago

Last modified 17 months ago

#10944 closed Patch - Bug Fix (fixed)

unbreak starting playback on a frontend fromt the recording details

Reported by: dekarl@… Owned by: danielk
Priority: minor Milestone: 0.26
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

appears to have been missed in the UTC conversion

Attachments (1)

10944-unbreak-playback-on-frontend.patch (1.3 KB) - added by dekarl@… 21 months ago.

Download all attachments as: .zip

Change History (9)

Changed 21 months ago by dekarl@…

comment:1 Changed 21 months ago by danielk

  • Owner changed from kormoc to danielk
  • Status changed from new to assigned

comment:2 Changed 21 months ago by danielk

  • Milestone changed from unknown to 0.26
  • Status changed from assigned to infoneeded

dekarl, the second part of the patch looks like a UTC issue, what is the root stuff about though?

comment:3 Changed 21 months ago by dekarl@…

I was debugging why the playback on frontend x function did not work and fixed both errors while on it.

Hitting the play on frontend button resulted in the following error

[Thu Jul 26 14:23:38 2012] [error] [client 192.168.66.137] PHP Fatal error:  require_once(): Failed opening required 'tv.php' (include_path='/usr/local/share/mythtv/bindings/php/:/usr/share/mythtv/bindings/php/:.:/usr/share/php:/usr/share/pear:/usr/share/mythtv/mythweb/modules/remote') in /usr/share/mythtv/mythweb/modules/remote/handler.php on line 100, referer: http://mythmaster.breitlacher/mythweb/tv/detail/2065/1337288700

looking at the (removed in the meantime) iPad template revealed that the relative path led to calling http://mythmaster.breitlacher/mythweb/remote/tv/detail/2065/1337288700 instead of just http://mythmaster.breitlacher/mythweb/tv/detail/2065/1337288700 (without the remote/ component) which was avoided by making the path absolute (by prepending "root.")

But that appears to just be a cosmetic error / red herring so I continued to debug which led me to the UTC issue. I never tested what happens if just the latter issues gets fixed.

comment:4 Changed 21 months ago by danielk

  • Status changed from infoneeded to assigned

comment:5 Changed 21 months ago by danielk

Unfortuntely, I seem to be unable to test this. I don't have any frontends listed as available for playback duties.

comment:6 Changed 21 months ago by Dekarl <dekarl@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In fced22b1d80c377cc2463eba1b67f2de79c6d634/mythtv:

Fixes #10944. Fix frontend playback button on mythweb details page.

Signed-off-by: Daniel Thor Kristjansson <danielk@…>

comment:7 Changed 21 months ago by danielk

Dekarl, the .root. stuff doesn't appear to be necessary. I'm not really the right person to review those types of changes, so I've just applied the necessary bit in bindings/php/MythFrontend.php.

comment:8 Changed 17 months ago by Karl Dietz <dekarl@…>

In 50c2a3448f46eed0d319c41970321f5326dc5a86/mythweb:

Mimick how modules/tv/detail.php refers to itself.

Silences "PHP Fatal error: require_once(): Failed opening required 'tv.php'"
in httpd error.log

Refs: #10944

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.