Opened 6 years ago

Closed 3 months ago

#11021 closed Patch - Bug Fix (Won't Fix)

DVBCam/CAM-Module initialized/used also with not encrypted channels

Reported by: Shinck@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.27.7
Component: MythTV - EIT Version: 0.25-fixes
Severity: medium Keywords: CAM EIT
Cc: Ticket locked: no

Description

SignalMonitor? or Recorder initializes CAM-Module and sends CA_PMT for all channels and programs, not only encrypted. They also do so for grabbing EIT-Data with EIT-Scans. All the time, every few minutes during EIT-Scan if channels change CAM is stopped and restarted (shows also up in syslog). So I decided to write a fix. Now the CAM is only initialized and CA_PMT is sent if a stream or program is encrypted and we want to record or look live-TV.

So now I provide the patch. Perhaps it could be helpful for some other people.

Attachments (6)

0001-No_decrypting_of_unencrypted_channels_or_during_EIT.patch (4.9 KB) - added by Shinck@… 6 years ago.
No use of CAM-Module and decrypting at EIT-Scan or not encrypted channels
version-linux.txt (865 bytes) - added by Shinck@… 6 years ago.
Version information
0002-No_decrypting_of_unencrypted_channels_or_during_EIT-026.patch (4.9 KB) - added by Shinck@… 6 years ago.
Patch for master / 0.26-rc
version026-linux.txt (876 bytes) - added by Shinck@… 6 years ago.
Version information 0.26
Version.txt (880 bytes) - added by Shinck@… 5 years ago.
0002-decrypt_two_channels_in_parallel.commit (12.2 KB) - added by Shinck@… 5 years ago.

Download all attachments as: .zip

Change History (21)

Changed 6 years ago by Shinck@…

No use of CAM-Module and decrypting at EIT-Scan or not encrypted channels

Changed 6 years ago by Shinck@…

Attachment: version-linux.txt added

Version information

comment:1 Changed 6 years ago by Shinck@…

Recently I switched from fixes/0.25 to master. The patch also works fine. So I will attach it here.

Changed 6 years ago by Shinck@…

Patch for master / 0.26-rc

Changed 6 years ago by Shinck@…

Attachment: version026-linux.txt added

Version information 0.26

comment:2 Changed 5 years ago by thomas@…

Can this be added to 0.26 fixes, please?

comment:3 Changed 5 years ago by Shinck@…>

In 32b0546e488aa07a87ef3704e93277258ee0fce1/mythtv:

Don't use the CAM when on an unencrypted channel or when
just looking for EIT data

Refs #11021

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:4 Changed 5 years ago by Stuart Auchterlonie

Milestone: unknown0.27
Status: newaccepted

comment:5 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In c2553d808078a9e45b57a94a61fb26ac35b99787/mythtv:

Fix build after 32b0546e488aa07a87ef3704e93277258ee0fce1

There should be no need to make DTVSignalMonitor dependent
on DVBChannel. I've reverted that part of the patch.

Refs #11021

comment:6 Changed 5 years ago by Shinck@…>

In 93f2d2b52ffcab1d20b220a9cfa3420fec5483f2/mythtv:

Don't use the CAM when on an unencrypted channel or when
just looking for EIT data

Refs #11021

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:7 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In d626d5667a7ddb8e2567cb6898130d997cd878da/mythtv:

Fix build after 32b0546e488aa07a87ef3704e93277258ee0fce1

There should be no need to make DTVSignalMonitor dependent
on DVBChannel. I've reverted that part of the patch.

Refs #11021

comment:8 Changed 5 years ago by thomas@…

Even after applying the 0.26 patch on 0.26 fixes, it still uses the CAM and decrypts the channel during EIT scan.

comment:9 Changed 5 years ago by Shinck@…

The last revert broke that the CAM doesn't decrypt channels during EIT scan.

I fixed this and make some optimization: If CAM-Module decrypts one channel it's now possible to add a second recording which needs also decryption without destroying the first or both recordings. During LiveTV it speeds up decryption at channel changes.

I attached the fix for fixes/0.26

Changed 5 years ago by Shinck@…

Attachment: Version.txt added

Changed 5 years ago by Shinck@…

comment:10 Changed 5 years ago by thomas@…

The newest patch does not apply to 0.26-fixes. I tried various versions up to 2013-06-30.

comment:11 Changed 5 years ago by SHinck@…

Try first applying 0002-No_decrypting_of_unencrypted_channels_or_during_EIT-026.patch​ and then 0002-decrypt_two_channels_in_parallel.commit​

comment:12 Changed 5 years ago by thomas@…

OK, applying both patches worked, thanks. However, it still decrypts during EIT scan.

comment:13 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.270.27.6

comment:14 Changed 2 years ago by dekarl

Milestone: 0.27.60.27.7

Reschedule all tickets planned for, but not solved in time for, 0.27.6 to 0.27.7.

comment:15 Changed 3 months ago by Stuart Auchterlonie

Resolution: Won't Fix
Status: acceptedclosed

Closing any remaining open tickets for 0.27

If the issue still persists, feel free to reopen and align to a current release (v29 or master)

Note: See TracTickets for help on using tickets.