Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#11098 closed Patch - Feature (fixed)

Rework table section accounting to remove code duplication

Reported by: Rune Petersen <rune@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 29.0
Component: MythTV - DVB Version: Master Head
Severity: medium Keywords: janitor rework mpeg tables
Cc: Ticket locked: no

Description

I felt like doing some (late) spring cleaning in the *StreamData? code and the table section accounting code seemed like an easy place to start.

The intent is to make the *StreamData? classes (especially MPEGStreamData) simpler/cleaner. And as a bonus it uses a little less memory =)

The patch creates two classes TableStatus? & TableStatusMap? for keeping account of a single table or map of tables, and then changes ATSCStreamData, MPEGStreamData, and DVBStreamData to make use of TableStatus?(Map) and removing the old functions.

Attachments (1)

mythtv_remove_code_duplication_in_mpeg_table_accounting.patch​ (40.0 KB) - added by Rune Petersen <rune@…> 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Rune Petersen <rune@…>

Attachment: mythtv_remove_code_duplication_in_mpeg_table_accounting.patch​ added

comment:1 Changed 7 years ago by danielk

Status: new → accepted

comment:2 Changed 4 years ago by Stuart Auchterlonie

Owner: danielk deleted
Status: accepted → new

comment:3 Changed 3 years ago by Stuart Auchterlonie

Milestone: unknown → 29.0
Owner: set to Stuart Auchterlonie
Status: new → accepted

comment:4 Changed 3 years ago by Rune Petersen <rune@…>

Resolution: → fixed
Status: accepted → closed

In 36e946d74522045302ee2ab543fa15f5d5e7cdbc/mythtv:

Fixes #11098 - Rework table section accounting to remove code duplication

Reworked by:

  • Roger James <roger@…>
  • Stuart Auchterlonie <stuarta@…>

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:5 Changed 3 years ago by Karl Dietz <dekarl@…>

In a8b2fe857eab31fa790f2aed070cf7ea40864465/mythtv:

Fix typo in table refactor in 36e946d74522045302ee2ab543fa15f5d5e7cdbc

Refs #11098
Refs #13002

Note: See TracTickets for help on using tickets.