Opened 5 years ago

Closed 5 years ago

#11339 closed Bug Report - General (fixed)

HLS Stream Progress > 100%

Reported by: jheizer@… Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27
Component: MythTV - Mythtranscode Version: 0.26-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If you start a HLS on a recording that is in progress the percentage reported grows greater than 100%.

Example:

<StartSegment>1</StartSegment>
<CurrentSegment>241</CurrentSegment>
<SegmentCount>241</SegmentCount>
<PercentComplete>14156</PercentComplete>

It does report 100% once complete.

<stichnot> jheizer: this is because Transcode::TranscodeFile?() calls GetTotalFrameCount?() outside the loop, so for percentage calculations it's using the frame count that was correct when the transcoding started.

<stichnot> jheizer: if you're willing to test, look for the line "int percentage = curFrameNum * 100 / total_frame_count;" and add a new statement right before it: "total_frame_count = GetPlayer?()->GetCurrentFrameCount?();" }}}

Change History (2)

comment:1 Changed 5 years ago by Jim Stichnoth

Component: MythTV - HTTP StreamingMythTV - Mythtranscode
Milestone: unknown0.27
Owner: changed from cpinkham to Jim Stichnoth
Status: newaccepted

comment:2 Changed 5 years ago by Jim Stichnoth <jstichnoth@…>

Resolution: fixed
Status: acceptedclosed

In ae8406425160e7e33a758904fe1b300a04dd8e64/mythtv:

Use the latest frame count when transcoding in-progress recordings.

Fixes #11339. Report reasonable percent completion status for HLS
transcodes of in-progress recordings.

Note: See TracTickets for help on using tickets.