Opened 3 years ago
Closed 3 years ago
Last modified 3 years ago
RemoteFile::Open() can leak MythSockets
|Reported by:||paulh <mythtv@…>||Owned by:||cpinkham|
|Component:||MythTV - General||Version:||Master Head|
RemoteFile::Open(void) doesn't check to see if it's sockets have already been opened so it's possible for some new sockets to be created without first closing and deleting the old ones.
Things are made worse by the fact that the RemoteFile? constructor will automatically call Open() if a url is passed to it.
These are a few places where a RemoteFile? is created with a url passed to it and later Open() is called :- There is one in MusicSGIODevice which is where I first spotted the problem while playing back tracks from the Music storage group. There is a couple in MetadataDownload? readMXML() and readNFO().
These all cause the Error: Not all threads were shut down properly: Thread MythSocketThread?(-1) is still running warnings when exiting the FE.
Change History (4)
comment:1 Changed 3 years ago by cpinkham
- Owner set to cpinkham
- Status changed from new to assigned
comment:2 Changed 3 years ago by Jim Stichnoth <jstichnoth@…>
comment:3 Changed 3 years ago by Chris Pinkham <cpinkham@…>
- Resolution set to fixed
- Status changed from assigned to closed
comment:4 Changed 3 years ago by cpinkham
- Milestone changed from unknown to 0.27