RemoteFile::Open() can leak MythSockets

[paulh <mythtv@…>]

RemoteFile::Open(void) doesn't check to see if it's sockets have already been opened so it's possible for some new sockets to be created without first closing and deleting the old ones.

Things are made worse by the fact that the RemoteFile? constructor will automatically call Open() if a url is passed to it.

These are a few places where a RemoteFile? is created with a url passed to it and later Open() is called :- There is one in MusicSGIODevice which is where I first spotted the problem while playing back tracks from the Music storage group. There is a couple in MetadataDownload? readMXML() and readNFO().

These all cause the Error: Not all threads were shut down properly: Thread MythSocketThread?(-1) is still running warnings when exiting the FE.

[Jim Stichnoth <jstichnoth@…>]

In ba75244a7f7e412bdb100b7741eaa6a6f0e6649b/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Chris Pinkham <cpinkham@…>]

In 4c9dc6d7eebe6853285efbe76a2f81ad80ebbc3c/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available