Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 15 months ago

Closed 15 months ago

Last modified 9 months ago

#11345 closed Patch - Feature (fixed)

Patch: Add support to use IMDB as reference in tmdb3.py

Reported by: gergnz@… Owned by: wagnerrp
Priority: minor Milestone: 0.27
Component: Contributed Scripts & Apps Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

From: https://github.com/MythTV/mythtv/pull/31

As tmpd3.py seems to support the output more metadata than tmdb.py but mythweb/video still uses imdb as key, I added support to tmdb3.py to lookup movies using IMDB id instead of only the the movie database reference.

Attachments (0)

Change History (3)

comment:1 Changed 15 months ago by Greg Cockburn <greg@…>

  • Resolution set to fixed
  • Status changed from new to closed

In c68e784d32192f69a066169b02a2135b0d1f101a/mythtv:

Add support for IMDB based lookups

I'm giving greg credit for this, but the method is significantly
differnet. This includes an explicit regular expression check to ensure
only zero-padded seven digit numbers are queried as IMDB IDs. This is to
prevent any risk of potential overlap with TMDB IDs, once their database
grows that large. This also does not bother applying the IMDB IDs to the
temporary VideoMetadata? object as MythTV does not attempt to do anything
with it.

Fixes #11345

Signed-off-by: Raymond Wagner <rwagner@…>

comment:2 Changed 15 months ago by wagnerrp

  • Milestone changed from unknown to 0.27
  • Owner changed from mdean to wagnerrp

comment:3 Changed 9 months ago by Greg Cockburn <greg@…>

In 248660c54fad143a3e0c4bafd39e037727629ef2/mythtv:

Add support for IMDB based lookups

I'm giving greg credit for this, but the method is significantly
differnet. This includes an explicit regular expression check to ensure
only zero-padded seven digit numbers are queried as IMDB IDs. This is to
prevent any risk of potential overlap with TMDB IDs, once their database
grows that large. This also does not bother applying the IMDB IDs to the
temporary VideoMetadata? object as MythTV does not attempt to do anything
with it.

Fixes #11345

Signed-off-by: Raymond Wagner <rwagner@…>
(cherry picked from commit c68e784d32192f69a066169b02a2135b0d1f101a)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.