Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#11364 closed Bug Report - General (fixed)

Possible non-thread-safe call to MythCoreContext::ConnectToMasterServer

Reported by: peper03@… Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

IdleScreen::CheckConnectionToServer? in MythFrontend calls MythCoreContext::ConnectToMasterServer?, which has the following comment:

Assumes that either m_sockLock is held, or the app is still single
threaded (i.e. during startup).

As m_sockLock cannot be accessed outside of MythCoreContext? and IdleScreen::CheckConnectionToServer? is triggered by a timer (i.e. not only at startup), it would appear that this call is not thread-safe.

The second patch (Added-SafeConnectToMasterServer?.diff​) in ticket #11238 provides a thread-safe wrapper, which could be called instead.

Attachments (0)

Change History (4)

comment:1 Changed 15 months ago by danielk

  • Owner set to stuartm
  • Status changed from new to assigned

Stuart M, I'm assigning this to you solely based on "git blame idlescreen.h"

comment:2 Changed 15 months ago by stuartm

That method was lifted without changes from mythwelcome, but I should have paid closer attention when I did it.

comment:3 Changed 15 months ago by Stuart Morgan <smorgan@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 15 months ago by wagnerrp

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.