Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11364 closed Bug Report - General (fixed)

Possible non-thread-safe call to MythCoreContext::ConnectToMasterServer

Reported by: peper03@… Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

IdleScreen::CheckConnectionToServer? in MythFrontend calls MythCoreContext::ConnectToMasterServer?, which has the following comment:

Assumes that either m_sockLock is held, or the app is still single threaded (i.e. during startup).

As m_sockLock cannot be accessed outside of MythCoreContext? and IdleScreen::CheckConnectionToServer? is triggered by a timer (i.e. not only at startup), it would appear that this call is not thread-safe.

The second patch (Added-SafeConnectToMasterServer?.diff​) in ticket #11238 provides a thread-safe wrapper, which could be called instead.

Change History (4)

comment:1 Changed 12 years ago by danielk

Owner: set to stuartm
Status: new → assigned

Stuart M, I'm assigning this to you solely based on "git blame idlescreen.h"

comment:2 Changed 12 years ago by stuartm

That method was lifted without changes from mythwelcome, but I should have paid closer attention when I did it.

comment:3 Changed 12 years ago by Stuart Morgan <smorgan@…>

Resolution: → fixed
Status: assigned → closed

In 3d3592447cbbab099b2e9516b5eecd67e44dca6b/mythtv:

Fix some unsafe usage of ConnectToMasterServer?(). Fixes #11364

comment:4 Changed 12 years ago by Raymond Wagner

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.