Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#11411 closed Patch - Bug Fix (fixed)

fix mythcommflag segfaults in mpeg2_fast_decode_block_non_intra

Reported by: thomas-joiner <thomas.b.joiner@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.27
Component: MythTV - Mythcommflag Version: 0.26-fixes
Severity: high Keywords:
Cc: Ticket locked: no

Description

Patch is a pull request: https://github.com/MythTV/mythtv/pull/37

The segfault in ticket #10222 is still causing problems for me.

The problem in that issue was that AvFormatDecoder? was adding the CODEC_FLAG2_FAST flag. This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.

I'm not sure that it is worth setting it up that way however, as I tested how this would affect the speed of mythcommflag on one of my recordings. The results (command used: time mythcommflag -f /path/to/file.mpg):

Before removing flag:

real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:

real 2m13.021s
user 2m15.446s
sys 0m3.758s

Change History (4)

comment:1 Changed 7 years ago by Stuart Auchterlonie

Milestone: unknown0.27
Owner: changed from cpinkham to Stuart Auchterlonie
Status: newassigned

comment:2 Changed 7 years ago by Stuart Auchterlonie <stuarta@…>

Resolution: fixed
Status: assignedclosed

In aaa5255f5bdf90233846e4c5c17e5d61fd7d500a/mythtv:

Merge remote-tracking branch 'thomas-joiner/bug_10222'

https://github.com/MythTV/mythtv/pull/37

Refs #10222
Closes #11411

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:3 Changed 7 years ago by Stuart Auchterlonie

Backported to 0.26-fixes in fdcc9c202b85c7d00b13aa5ee1232113382110fa

comment:4 Changed 7 years ago by Stuart Auchterlonie

Backported to 0.25-fixes in 947bb60fa9f3a7e7fd0c5d4300df1cdb9b3d4745

Note: See TracTickets for help on using tickets.