5cced61dd causes stuttering on UK Channel 4 HD recordings

[mythtv@…]

Since updating past ​https://github.com/MythTV/mythtv/commit/5ccedb61ddd2fa87b426cd1c0fbc43d2645cb9a5 recordings from channel 4 HD have become unwatchable. It plays about half a second of video + audio, then freezes for a second etc.

There was a frontend error message about not being enough video frames buffered - I will grab a frontend log when I get a chance.

I built latest master with this one commit removed (using git rebase) and playback performs normally once again.

[mythtv@…]

I have also tried rebuilding the seektable of a broken recording, which doesn't seem to fix the issue.

[mythtv@…]

I'm not sure if this is relevant, but part of the patch doesn't look consistent with itself.

In dtvrecorder.cpp, there is a frameRateMap array, which is initialized using the FrameRate? constructor. For fractional values, these are initialised as FrameRate?(24000, 1001), FrameRate?(30000, 1001) and FrameRate?(60000, 1001). The prototype for this constructor is FrameRate?(uint n, uint d=1).

Elsewhere in the code, AVRational is initialised with a similar constructor AVRational AVRationalInit(int num, int den = 1), and it is called in avformatdecoder.cpp with pkt_dur = AVRationalInit(1001, 60000);

I am not entirely sure of the usage of AVRational, but it would seem that the arguments are swapped (den = 1001 in the FrameRate? constructor, num = 1001 in the AVRational one). Looking at the code I suspect that the FrameRate? constructor is being called incorrectly, but I can't be sure.

[Jim Stichnoth <jstichnoth@…>]

In b174418db53559939cad7b8f9642c0b298849bcf/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Jim Stichnoth <jstichnoth@…>]

In 444e8ee017acc4cf0fa6a04a1bc8e350430108e4/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available