Opened 6 years ago

Closed 6 years ago

#11465 closed Patch - Feature (Won't Fix)

dvdringbuffer.cpp GetFrameRate patch to eliminate the need for local libdvdnav patches

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by:
Priority: minor Milestone: unknown
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords: GetFrameRate libdvdnav
Cc: Ticket locked: no

Description

This is a proposed patch to eliminate the last need to locally modify libdvdnav. This patch is (admittedly) a hack that indirectly determines the video_format based on the returned video_resolution, but due to the DVD standards, one that is reasonably stable.

This patch does not eliminate the local patches to libdvdnav. That would be in some future patch that might also move the library to the external directory.

This patch has been only lightly tested (I only have a few DVDs, and all are NTSC; in particular, no testing with PAL DVDs). Caveat Emptor.

Patch available at: https://github.com/garybuhrmaster/mythtv/commit/e3b5e977be7755a5e686eb6ccaab4eab3ea7b553

Change History (2)

comment:1 Changed 6 years ago by Gary Buhrmaster <gary.buhrmaster@…>

As the submitter of this ticket, I recommend this be closed "wontfix", since conversation on irc stated that there are other local patches for libdvdnav that will require libdvdnav to continue to be ported, and that there is work in progress that would eliminate the entire function (making these changes moot, and also eliminating the need for the referenced particular local patch to libdvdnav).

comment:2 Changed 6 years ago by sphery

Resolution: Won't Fix
Status: newclosed

Closing at submitter's request, as described in comment:1

Note: See TracTickets for help on using tickets.