Opened 7 years ago

Closed 7 years ago

#11537 closed Bug Report - General (Fixed)

Taglib configure change breaks some nonstandard setups

Reported by: Jim Stichnoth Owned by: paulh
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

One of the commits between f434ac6e3b09c9bbb33c90b41675f79bfca339bf and aa7b3974281932a3d8ab19f896a2b76473272932 (adding taglib to the main mythtv build) causes build problems in some setups, due to the output of "taglib-config --libs" being inserted into the linker command lines.

In my case, I have a Ubuntu 10.04 system with Qt 4.6 installed, and I have built and installed Qt 4.8 in a nonstandard location, and put that location near the front of $PATH and $LD_LIBRARY_PATH to make things work out. With the taglib change, -L/usr/lib is added to the linker command line before the path to Qt 4.8, causing the linker to try to link in the Qt 4.6 libraries.

I have a small patch that simply strips -L/usr/lib from the taglib-config output, but perhaps there is a better way.

Attachments (1)

taglib.patch (509 bytes) - added by Jim Stichnoth 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Jim Stichnoth

Attachment: taglib.patch added

comment:1 Changed 7 years ago by paulh

If you change the check to

if test $taglib_minor -lt 6 || ! check_class_headers_cpp taglib/fileref.h TagLib::FileRef $tagincludes $taglibs -lstdc++; then

does that work?

It looks like check_class_headers_cpp should do the same checks as check_lib_cpp but wont add the flags to extralibs.

comment:2 Changed 7 years ago by Jim Stichnoth

Thanks - yes, that change results in successful linking on my system.

comment:3 Changed 7 years ago by Jim Stichnoth

Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.