Opened 12 years ago

Closed 12 years ago

#11557 closed Patch - Bug Fix (Fixed)

Patch for cosmetic (false positive) static analysis bug in cc708decoder.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27
Component: MythTV - Captions Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (scan-build) indicates that the variable seq_num in cc708decoder.cpp is assigned a value and not used. This is due to the debug defines that evaluate to 0, and the code that could reference the variable would not be ever reached (according to the static analysis).

Moving the variable inside the debug block next to the other variables used only inside the block causes no harm, and eliminates the reported misuse.

​https://github.com/garybuhrmaster/mythtv/commit/95af348bb0908896b84575c2d121336742ae36ba

Change History (2)

comment:1 Changed 12 years ago by Jim Stichnoth

Milestone: unknown → 0.27
Status: new → accepted

comment:2 Changed 12 years ago by Jim Stichnoth

Resolution: → Fixed
Status: accepted → closed

Fixed in 887e60b06961e51649febc1ebfd8028671505334

Note: See TracTickets for help on using tickets.