Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11592 closed Patch - Bug Fix (fixed)

Patch to correct check for null pointer from function in audiooutputpulse.cpp - fixes coverity 700280

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: JYA
Priority: minor Milestone: 0.27
Component: MythTV - Audio Output Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In 1e1e550 code was added to call pa_channel_map_init_auto and check the result. This patch corrects that check for a null pointer.

Fixes coverity 700280 ("Operands don't affect result" because the previous comparison was always false)

Patch: https://github.com/garybuhrmaster/mythtv/commit/78ddf38354312cdeecccd6030becb78b86b797bf.patch

Change History (4)

comment:1 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

This patch should also fix coverity 700382 (I missed the second defect in report)

comment:2 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Should also fix coverity 700298 (I missed the third defect in the report).

comment:3 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In 98614122e6658c9b5c9c2d79c7756b4bffd5f538/mythtv:

Correct check for null pointer return

In 1e1e5500 code was added to call pa_channel_map_init_auto,
and check the result. This patch corrects that check for
a null pointer.

Fixes coverity 700280
(cherry picked from commit 78ddf38354312cdeecccd6030becb78b86b797bf)

Fixes #11592

Signed-off-by: Stuart Morgan <smorgan@…>

comment:4 Changed 5 years ago by paulh

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.