Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11609 closed Patch - Bug Fix (fixed)

DVD bookmarks are unreliable

Reported by: peper03@… Owned by: Richard <peper03@…>
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

DVD bookmarks are currently stored by saving the title and frame number along with the selected audio and subtitle tracks. This works for some DVDs but not for others. Any DVD making use of values stored in the general purpose registers will have problems.

The attached patch adds code to store and restore the complete state of the DVD VM. As this contains all the information the VM had at the time the bookmark was created, resuming from a bookmark should be completely reliable.

Reading of existing bookmarks is supported with this patch but only the new state data will be written.

Attachments (1)

0001-Implement-DVD-bookmarks-by-saving-and-restoring-the-.patch (29.8 KB) - added by peper03@… 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by peper03@…

comment:1 Changed 6 years ago by Richard <peper03@…>

Owner: set to Richard <peper03@…>
Resolution: fixed
Status: newclosed

In 4f023d72227d6f3be654fc1615483290674c288d/mythtv:

Implement DVD bookmarks by saving and restoring the full DVD VM's state to make playback from bookmarks more reliable for all DVDs.

The state snapshot code is borrowed/adapted from or inspired by XBMC and Ogle.

Existing bookmarks are supported but will be converted if stored again.

Fixes #11609

comment:2 Changed 6 years ago by peper03

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.