Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11622 closed Patch - Bug Fix (fixed)

Patch to remove unused member variable m_imr in MBroadcastSocketDevice - fixes coverity 746874

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Remove unused member variable m_imr in MBroadcastSocketDevice

The member variable m_imr appears to be a carryover from a code copy/paste from the multicast socket class (where it is used for the group address). It is unused in a broadcast socket. Remove it.

Fixes coverity 746874

NOTE: This modifies the binary ABI version number due to the mbroadcastsocket.h changes, so make distclean, etc. required.

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/5e15740501d9e89c0eba71d8ae97c16c3b737495

github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/5e15740501d9e89c0eba71d8ae97c16c3b737495.patch

Change History (3)

comment:1 Changed 12 years ago by stuartm

Owner: set to stuartm
Status: new → accepted

comment:2 Changed 12 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: accepted → closed

In f86ce897e414c14b07e9bce8647c6813dee6490c/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:3 Changed 12 years ago by paulh

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.