Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#11622 closed Patch - Bug Fix (fixed)

Patch to remove unused member variable m_imr in MBroadcastSocketDevice - fixes coverity 746874

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Remove unused member variable m_imr in MBroadcastSocketDevice

The member variable m_imr appears to be a carryover from a code copy/paste from the multicast socket class (where it is used for the group address). It is unused in a broadcast socket. Remove it.

Fixes coverity 746874

NOTE: This modifies the binary ABI version number due to the mbroadcastsocket.h changes, so make distclean, etc. required.

github ref: https://github.com/garybuhrmaster/mythtv/commit/5e15740501d9e89c0eba71d8ae97c16c3b737495

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/5e15740501d9e89c0eba71d8ae97c16c3b737495.patch

Attachments (0)

Change History (3)

comment:1 Changed 10 months ago by stuartm

  • Owner set to stuartm
  • Status changed from new to accepted

comment:2 Changed 10 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In f86ce897e414c14b07e9bce8647c6813dee6490c/mythtv:

Remove unused member variable m_imr in MBroadcastSocketDevice

The member variable m_imr appears to be a carryover
from a code copy/paste from the multicast socket
class (where it is used for the group address).
It is unused in a broadcast socket. Remove it.

Fixes coverity 746874
Fixes #11622

NOTE: This modifies the binary ABI version number

due to the mbroadcastsocket.h changes, so
make distclean, etc. required.

(cherry picked from commit 5e15740501d9e89c0eba71d8ae97c16c3b737495)

Signed-off-by: Stuart Morgan <smorgan@…>

comment:3 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.