Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11625 closed Patch - Bug Fix (fixed)

Patch to initialize fd_set in MythSystemLegacyIOHandler ctor - fixes coverity 1028698

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis detected that the fd_set was not being initialized in the ctor. While correct from a static analysis POV, the structure was being initialized elsewhere before use. To make static analysis happy, initialize the fd_set.

Fixes coverity 1028698

Note that coverity may not properly understand that the use of the provided FD_ZERO macro will properly initialize the structure since on some platforms (i.e. x86) the macro turns into inline assembly code. In the case that adding the patch does not eliminate the coverity issue, one will need to manually acknowledge the defect.

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/7323bf7a71b42f379f139b57524b82e1ff28d6bc

github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/7323bf7a71b42f379f139b57524b82e1ff28d6bc.patch

Change History (2)

comment:1 Changed 12 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: → fixed
Status: new → closed

In b37d3cfb35d79ff944c232c142ad4de42f29b5a6/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:2 Changed 12 years ago by paulh

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.