Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#11630 closed Patch - Bug Fix (fixed)

Path to properly handle fd number 0 in MythSystemLegacySignalManager

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Visual analysis (IEAEYEBALL) detected that the check for the file descriptor value should be "fd >= 0" and not just "fd > 0". While a fd of zero is commonly stdin, do the right check just in case.

The CLOSE macro properly performs the check for greater than or equal to zero. This patch just does the same thing inline.

github ref: https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650.patch

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Owner set to Gary Buhrmaster <gary.buhrmaster@…>
  • Resolution set to fixed
  • Status changed from new to closed

In c416822518b60b725b7e564e89f4321646d89a74/mythtv:

Properly handle fd number 0 in signal manager

Visual analysis (IEAEYEBALL) detected that the
check for the file descriptor value should be
"fd >= 0" and not just "fd > 0". While a fd of
zero is commonly stdin, do the right check just
in case.

The CLOSE macro properly performs the check
for greater than or equal to zero. This
patch just does the same thing.

Fixes #11630.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.