Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11630 closed Patch - Bug Fix (fixed)

Path to properly handle fd number 0 in MythSystemLegacySignalManager

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Visual analysis (IEAEYEBALL) detected that the check for the file descriptor value should be "fd >= 0" and not just "fd > 0". While a fd of zero is commonly stdin, do the right check just in case.

The CLOSE macro properly performs the check for greater than or equal to zero. This patch just does the same thing inline.

github ref: https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650.patch

Change History (2)

comment:1 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: fixed
Status: newclosed

In c416822518b60b725b7e564e89f4321646d89a74/mythtv:

Properly handle fd number 0 in signal manager

Visual analysis (IEAEYEBALL) detected that the
check for the file descriptor value should be
"fd >= 0" and not just "fd > 0". While a fd of
zero is commonly stdin, do the right check just
in case.

The CLOSE macro properly performs the check
for greater than or equal to zero. This
patch just does the same thing.

Fixes #11630.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 5 years ago by paulh

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.