Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11855 closed Bug Report - General (fixed)

null character at the end of text captions

Reported by: rjmorris.list@… Owned by: Jim Stichnoth
Priority: minor Milestone: 0.26.2
Component: MythTV - Captions Version: 0.26-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When displaying text captions in videos created by Handbrake, MythTV prints an empty rectangle, representing a non-printable character, at the end of each caption. Inspection of the log messages suggests that the non-printable character is a null character (0x00). It is unclear whether the captions in the video file are stored incorrectly or whether MythTV makes an error when reading them.

Attachments (2)

rawtextsubs.patch (657 bytes) - added by Jim Stichnoth 6 years ago.
sample.mkv (1.4 MB) - added by Joey Morris <rjmorris.list@…> 6 years ago.
short clip containing subtitles demonstrating the problem

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by Jim Stichnoth

Attachment: rawtextsubs.patch added

comment:1 Changed 6 years ago by Jim Stichnoth

Status: newaccepted

Can you try the attached patch? It's against 0.27 / Master but I expect it should apply to 0.26.

comment:2 Changed 6 years ago by Joey Morris <rjmorris.list@…>

The patch fixed the problem. Thanks!

comment:3 Changed 6 years ago by Jim Stichnoth

Milestone: unknown0.27

comment:4 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

Resolution: fixed
Status: acceptedclosed

In b062dd43ba26836c854a0c8fda845f9997b8fba9/mythtv:

Subtitles: Remove extraneous character in embedded text subtitles.

The NUL character at the end of the C string was accidentally being
included as part of the subtitle string, and rendered to the screen.
This affected only "raw text" subtitles directly embedded into the
video. Fixes #11855.

comment:5 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In ebf2b54082589052c715b2b7615ef9489721d6f9/mythtv:

Subtitles: Remove extraneous character in embedded text subtitles.

The NUL character at the end of the C string was accidentally being
included as part of the subtitle string, and rendered to the screen.
This affected only "raw text" subtitles directly embedded into the
video. Fixes #11855.
(cherry picked from commit b062dd43ba26836c854a0c8fda845f9997b8fba9)

comment:6 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In 7892e197d0baee8f734b5f2dabc6751125ed9ffc/mythtv:

Subtitles: Remove extraneous character in embedded text subtitles.

The NUL character at the end of the C string was accidentally being
included as part of the subtitle string, and rendered to the screen.
This affected only "raw text" subtitles directly embedded into the
video. Fixes #11855.
(cherry picked from commit b062dd43ba26836c854a0c8fda845f9997b8fba9)

comment:7 Changed 6 years ago by Jim Stichnoth

Milestone: 0.270.26.2

Changed 6 years ago by Joey Morris <rjmorris.list@…>

Attachment: sample.mkv added

short clip containing subtitles demonstrating the problem

Note: See TracTickets for help on using tickets.